Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 213363006: Oilpan: Add [WillBeGarbageCollected] to Event.idl (Closed)

Created:
6 years, 9 months ago by haraken
Modified:
6 years, 9 months ago
CC:
blink-reviews, shans, jsbell+idb_chromium.org, tzik, gasubic, eae+blinkwatch, fs, eric.carlson_apple.com, nessy, apavlov+blink_chromium.org, adamk+blink_chromium.org, Steve Block, dino_apple.com, rune+blink, Nils Barth (inactive), jsbell+serviceworker_chromium.org, Nate Chapin, arv+blink, alancutter (OOO until 2018), marja+watch_chromium.org, alecflett, Timothy Loh, abarth-chromium, aandrey+blink_chromium.org, dstockwell, dglazkov+blink, Rik, pdr., rwlbuis, Eric Willigers, philipj_slow, rjwright, mvanouwerkerk+watch_chromium.org, sof, kouhei+svg_chromium.org, Raymond Toy, timvolodine, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, krit, gyuyoung.kim_webkit.org, darktears, haraken, kojih, vcarbune.chromium, alecflett+watch_chromium.org, kinuko, jsbell+bindings_chromium.org, nhiroki, horo+watch_chromium.org, kouhei+bindings_chromium.org, ericu+idb_chromium.org, serviceworker-reviews, falken, Mike Lawther (Google), ed+blinkwatch_opera.com, f(malita), Inactive, cmumford, dgrogan, Stephen Chennney, watchdog-blink-watchlist_google.com, Mikhail
Visibility:
Public.

Description

Oilpan: Add [WillBeGarbageCollected] to Event.idl This is a minimal change to make [WillBeGarbageCollected] in Event.idl workable. - This CL adds [WillBeGarbageCollected] to Event.idl and makes minimal changes to the code base to make it workable. - This CL is almost just replacing: PassRefPtr<XEvent> XEvent::create() { return adoptRef(new XEvent); } with PassRefPtrWillBeRawPtr<XEvent> XEvent::create() { return adoptRefWillBeRefCountedGarbageCollected(new XEvent); } BUG=340522 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170164

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+376 lines, -359 lines) Patch
M Source/bindings/templates/interface.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.h View 3 chunks +7 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp View 4 chunks +5 lines, -3 lines 0 comments Download
M Source/build/scripts/templates/EventFactory.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFontFaceLoadEvent.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/dom/Document.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/AutocompleteErrorEvent.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/events/BeforeTextInsertedEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/events/BeforeUnloadEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/events/ClipboardEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/events/CompositionEvent.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/events/CustomEvent.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/events/ErrorEvent.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/events/Event.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/events/Event.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/events/EventFactory.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/events/FocusEvent.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/events/GestureEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/GestureEvent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/HashChangeEvent.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/events/KeyboardEvent.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/events/MessageEvent.h View 1 chunk +15 lines, -15 lines 0 comments Download
M Source/core/events/MessageEvent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/events/MouseEvent.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/events/MouseEvent.cpp View 2 chunks +7 lines, -6 lines 0 comments Download
M Source/core/events/MutationEvent.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/events/OverflowEvent.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/events/PageTransitionEvent.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/events/PopStateEvent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/events/PopStateEvent.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/events/ProgressEvent.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/events/ResourceProgressEvent.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/events/SecurityPolicyViolationEvent.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/events/TextEvent.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/events/TextEvent.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/events/TouchEvent.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/events/TransitionEvent.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/events/UIEvent.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/events/WebKitAnimationEvent.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/events/WheelEvent.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/html/MediaKeyEvent.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/canvas/WebGLContextEvent.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/html/track/TrackEvent.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/speech/SpeechInputEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/speech/SpeechInputEvent.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/storage/StorageEvent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/storage/StorageEvent.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGZoomEvent.h View 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequestProgressEvent.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/device_orientation/DeviceMotionEvent.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/device_orientation/DeviceOrientationEvent.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeyMessageEvent.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeyNeededEvent.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/gamepad/GamepadEvent.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/modules/indexeddb/IDBVersionChangeEvent.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/modules/mediastream/MediaStreamEvent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/mediastream/MediaStreamEvent.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/modules/mediastream/MediaStreamTrackEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/MediaStreamTrackEvent.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/mediastream/RTCDTMFToneChangeEvent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/mediastream/RTCDTMFToneChangeEvent.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/modules/mediastream/RTCDataChannelEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCDataChannelEvent.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/mediastream/RTCIceCandidateEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCIceCandidateEvent.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/serviceworkers/FetchEvent.h View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/FetchEvent.cpp View 2 chunks +9 lines, -4 lines 0 comments Download
M Source/modules/serviceworkers/InstallEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/InstallEvent.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/serviceworkers/InstallPhaseEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/InstallPhaseEvent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionError.h View 1 chunk +3 lines, -3 lines 2 comments Download
M Source/modules/speech/SpeechRecognitionError.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionEvent.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisEvent.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/webaudio/AudioProcessingEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webaudio/AudioProcessingEvent.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/webaudio/OfflineAudioCompletionEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webaudio/OfflineAudioCompletionEvent.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/webmidi/MIDIConnectionEvent.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/modules/webmidi/MIDIMessageEvent.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/modules/websockets/CloseEvent.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/web/tests/CustomEventTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
haraken
PTAL
6 years, 9 months ago (2014-03-27 05:50:23 UTC) #1
Mads Ager (chromium)
LGTM https://codereview.chromium.org/213363006/diff/20001/Source/modules/speech/SpeechRecognitionError.h File Source/modules/speech/SpeechRecognitionError.h (right): https://codereview.chromium.org/213363006/diff/20001/Source/modules/speech/SpeechRecognitionError.h#newcode67 Source/modules/speech/SpeechRecognitionError.h:67: virtual void trace(Visitor* visitor) OVERRIDE Looks like this ...
6 years, 9 months ago (2014-03-27 09:01:51 UTC) #2
haraken
tkent: Would you rubberstamp to web/ ? https://codereview.chromium.org/213363006/diff/20001/Source/modules/speech/SpeechRecognitionError.h File Source/modules/speech/SpeechRecognitionError.h (right): https://codereview.chromium.org/213363006/diff/20001/Source/modules/speech/SpeechRecognitionError.h#newcode67 Source/modules/speech/SpeechRecognitionError.h:67: virtual void ...
6 years, 9 months ago (2014-03-27 09:13:58 UTC) #3
tkent
lgtm
6 years, 9 months ago (2014-03-27 09:26:53 UTC) #4
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-27 09:31:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/213363006/20001
6 years, 9 months ago (2014-03-27 09:31:18 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 09:41:09 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-27 09:41:09 UTC) #8
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-27 10:47:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/213363006/20001
6 years, 9 months ago (2014-03-27 10:47:11 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 10:48:06 UTC) #11
Message was sent while issue was closed.
Change committed as 170164

Powered by Google App Engine
This is Rietveld 408576698