third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp - Issue 2133603002: Fix crash when removing contents from a document having multiple bodies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp

Issue 2133603002: Fix crash when removing contents from a document having multiple bodies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Handle LayoutScrollbarPart aliveness Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutScrollbarPart.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp b/third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp

index f5b375e69f34729fad35d7b1fc39ef3a239587ee..e88385e0600c47a21b2fb98ea209e0a697e9aef4 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp

@@ -181,10 +181,8 @@ void LayoutObjectChildList::invalidatePaintOnRemoval(LayoutObject& oldChild)

{

if (!oldChild.isRooted())

return;

- if (oldChild.isBody()) {

+ if (oldChild.isBody())

oldChild.view()->setShouldDoFullPaintInvalidation();

- return;

- }

oldChild.slowSetPaintingLayerNeedsRepaint();

oldChild.invalidatePaintOfPreviousPaintInvalidationRect(oldChild.containerForPaintInvalidation(), PaintInvalidationLayoutObjectRemoval);

}