third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 2133603002: Fix crash when removing contents from a document having multiple bodies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2133603002: Fix crash when removing contents from a document having multiple bodies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Handle LayoutScrollbarPart aliveness Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/paint/invalidation/multiple-body-remove-selection-crash-expected.txt ('k') | third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index 985302668f0a8ea807e83e05ed286ea613998074..4b515c55dd0131319d337d884c962202a27bf1f1 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -2621,10 +2621,6 @@ void FrameView::synchronizedPaint()

if (!layoutViewItem.isNull())

layoutViewItem.layer()->clearNeedsRepaintRecursively();

});

-#if CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS

- DisplayItemClient::endShouldKeepAliveAllClients();

-#endif

}

void FrameView::synchronizedPaintRecursively(GraphicsLayer* graphicsLayer)