Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2127353003: Include "recipe_result" (None) on StepFailure (Closed)

Created:
4 years, 5 months ago by Paweł Hajdan Jr.
Modified:
4 years, 5 months ago
Reviewers:
estaab, iannucci, martiniss
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
https://github.com/luci/recipes-py.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Include "recipe_result" (None) on StepFailure This prevents the build from being marked as an infra failure, see https://codereview.chromium.org/2133573004 . More specifically, we always generate JSON output unless there was an infra failure. BUG=chromium:593999 Committed: https://github.com/luci/recipes-py/commit/9d78ba349aba023d424f6bfd483bdf4e5add9de5

Patch Set 1 #

Patch Set 2 : trybots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M recipe_engine/run.py View 1 chunk +2 lines, -0 lines 0 comments Download
M recipe_modules/generator_script/example.expected/always_run.json View 1 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/step/example.expected/defer_results.json View 1 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/step/example.expected/timeout.json View 1 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/step/example.expected/warning.json View 1 1 chunk +1 line, -0 lines 0 comments Download
M recipes/example/defer.expected/one_fail.json View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
Paweł Hajdan Jr.
4 years, 5 months ago (2016-07-08 15:10:08 UTC) #2
martiniss
lgtm
4 years, 5 months ago (2016-07-08 20:29:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127353003/20001
4 years, 5 months ago (2016-07-11 08:02:08 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 08:04:05 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/recipes-py/commit/9d78ba349aba023d424f6bfd483bdf4e5ad...

Powered by Google App Engine
This is Rietveld 408576698