Minor fixes in login_database.* and sql/statement.*

Minor fixes in login_database.* and sql/statement.*

This CL fixes a couple of style nits pointed out by lint in login_database.*, and also changes
sql::Statement::ColumnBlobAsString to const.

BUG=413020
Committed: https://crrev.com/b194fc5678593be3c9b15f6f61ea15a2c2384659
Cr-Commit-Position: refs/heads/master@{#405089}

[vabr (Chromium), 2016-07-08 19:20:43]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-08 19:21:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-07-08 19:42:40]

vabr@chromium.org changed reviewers:
+ msramek@chromium.org

[vabr (Chromium), 2016-07-08 19:42:41]

Hi Martin,

PTAL.

Thanks!
Vaclav

[commit-bot: I haz the power, 2016-07-08 21:27:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 21:27:43]

Dry run: This issue passed the CQ dry run.

[msramek, 2016-07-11 11:28:08]

LGTM with one suggestion.

https://codereview.chromium.org/2133173003/diff/1/components/password_manager...
File components/password_manager/core/browser/login_database.h (right):

https://codereview.chromium.org/2133173003/diff/1/components/password_manager...
components/password_manager/core/browser/login_database.h:182: sql::Statement*
s);
Should we make this const?

(which would actually allow us to keep the reference if we want to)

[vabr (Chromium), 2016-07-11 12:39:31]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-11 12:40:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-07-11 12:41:02]

Description was changed from

==========
Fix lint errors in login_database.*

Fixed a couple of style nits pointed out by lint.

BUG=413020
==========

to

==========
Minor fixes in login_database.* and sql/statement.*

This CL fixes a couple of style nits pointed out by lint in login_database.*,
and also changes 
sql::Statement::ColumnBlobAsString to const.

BUG=413020
==========

[vabr (Chromium), 2016-07-11 12:42:31]

vabr@chromium.org changed reviewers:
+ gbillock@chromium.org

[vabr (Chromium), 2016-07-11 12:42:32]

Thanks, Martin, comment addressed.

Greg, could you please review sql/* ?

Cheers,
Vaclav

https://codereview.chromium.org/2133173003/diff/1/components/password_manager...
File components/password_manager/core/browser/login_database.h (right):

https://codereview.chromium.org/2133173003/diff/1/components/password_manager...
components/password_manager/core/browser/login_database.h:182: sql::Statement*
s);
On 2016/07/11 11:28:08, msramek wrote:
> Should we make this const?
> 
> (which would actually allow us to keep the reference if we want to)

Done, including the yak-shaving to make it possible :).

[commit-bot: I haz the power, 2016-07-11 13:45:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 13:45:52]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-07-12 16:28:29]

vabr@chromium.org changed reviewers:
+ brettw@chromium.org

[vabr (Chromium), 2016-07-12 16:28:30]

Hi Brett,

Could you please review adding the "const" keyword into sql/statement.* here?

(From sql/OWNERS shess@ is OOO until August and I'm not sure to which extent
gbillock@ is still active in Chromium.)

Thanks,
Vaclav

[brettw, 2016-07-12 20:16:49]

lgtm

[vabr (Chromium), 2016-07-13 07:33:10]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2016-07-13 07:33:11]

The patchset sent to the CQ was uploaded after l-g-t-m from msramek@chromium.org
Link to the patchset: https://codereview.chromium.org/2133173003/#ps60001
(title: "Fix typos")

[commit-bot: I haz the power, 2016-07-13 07:33:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 08:46:58]

Description was changed from

==========
Minor fixes in login_database.* and sql/statement.*

This CL fixes a couple of style nits pointed out by lint in login_database.*,
and also changes 
sql::Statement::ColumnBlobAsString to const.

BUG=413020
==========

to

==========
Minor fixes in login_database.* and sql/statement.*

This CL fixes a couple of style nits pointed out by lint in login_database.*,
and also changes 
sql::Statement::ColumnBlobAsString to const.

BUG=413020
==========

[commit-bot: I haz the power, 2016-07-13 08:47:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-13 08:47:12]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 08:49:35]

Description was changed from

==========
Minor fixes in login_database.* and sql/statement.*

This CL fixes a couple of style nits pointed out by lint in login_database.*,
and also changes 
sql::Statement::ColumnBlobAsString to const.

BUG=413020
==========

to

==========
Minor fixes in login_database.* and sql/statement.*

This CL fixes a couple of style nits pointed out by lint in login_database.*,
and also changes
sql::Statement::ColumnBlobAsString to const.

BUG=413020

Committed: https://crrev.com/b194fc5678593be3c9b15f6f61ea15a2c2384659
Cr-Commit-Position: refs/heads/master@{#405089}
==========

[commit-bot: I haz the power, 2016-07-13 08:49:36]

Patchset 4 (id:??) landed as
https://crrev.com/b194fc5678593be3c9b15f6f61ea15a2c2384659
Cr-Commit-Position: refs/heads/master@{#405089}