Minor fixes in login_database.* and sql/statement.*

components/password_manager/core/browser/login_database.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_LOGIN_DATABASE_H_
 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_LOGIN_DATABASE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 18 matching lines @@
 namespace password_manager {
 
 extern const int kCurrentVersionNumber;
 extern const int kCompatibleVersionNumber;
 
 // Interface to the database storage of login information, intended as a helper
 // for PasswordStore on platforms that need internal storage of some or all of
 // the login information.
 class LoginDatabase {
  public:
-  LoginDatabase(const base::FilePath& db_path);
+  explicit LoginDatabase(const base::FilePath& db_path);
   virtual ~LoginDatabase();
 
   // Actually creates/opens the database. If false is returned, no other method
   // should be called.
   virtual bool Init();
 
   // Reports usage metrics to UMA.
   void ReportMetrics(const std::string& sync_username,
                      bool custom_passphrase_sync_enabled);
 
@@ skipping 122 matching lines @@
 
   bool InitLoginsTable();
   bool MigrateOldVersionsAsNeeded();
 
   // Fills |form| from the values in the given statement (which is assumed to
   // be of the form used by the Get*Logins methods).
   // Returns the EncryptionResult from decrypting the password in |s|; if not
   // ENCRYPTION_RESULT_SUCCESS, |form| is not filled.
   static EncryptionResult InitPasswordFormFromStatement(
       autofill::PasswordForm* form,
-      sql::Statement& s);
+      sql::Statement* s);

[msramek, 2016/07/11 11:28:08]

Should we make this const?

(which would actually allow us to keep the reference if we want to)

[vabr (Chromium), 2016/07/11 12:42:32]

Done, including the yak-shaving to make it possible :).

 
   // Gets all blacklisted or all non-blacklisted (depending on |blacklisted|)
   // credentials. On success returns true and overwrites |forms| with the
   // result.
   bool GetAllLoginsWithBlacklistSetting(
       bool blacklisted,
       ScopedVector<autofill::PasswordForm>* forms) const;
 
   // Overwrites |forms| with credentials retrieved from |statement|. If
   // |matched_form| is not null, filters out all results but those PSL-matching
@@ skipping 13 matching lines @@
   // This is a temporary measure for migration the Keychain on Mac.
   // crbug.com/466638
   bool clear_password_values_;
 
   DISALLOW_COPY_AND_ASSIGN(LoginDatabase);
 };
 
 }  // namespace password_manager
 
 #endif  // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_LOGIN_DATABASE_H_