Issue 2133143002: Fix an error in multipart_test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2133143002: Fix an error in multipart_test (Closed)

Created:
4 years, 5 months ago by Bill Hesse

Modified:
4 years, 5 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/http.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix an error in multipart_test R=nweiz@google.com Committed: https://github.com/dart-lang/http/commit/5c2f79fe79ea60adf8665a18a2b1ff49de677bb7

Patch Set 2 : Version .4-dev #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
M	CHANGELOG.md	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/multipart_test.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

nweiz

LGTM! https://codereview.chromium.org/2133143002/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/2133143002/diff/1/pubspec.yaml#newcode2 pubspec.yaml:2: version: 0.11.3+9 Nit: can you make this 0.11.4-dev? ...

4 years, 5 months ago (2016-07-08 19:57:01 UTC) #3

Bill Hesse

4 years, 5 months ago (2016-07-08 20:04:38 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
5c2f79fe79ea60adf8665a18a2b1ff49de677bb7 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 2133143002: Fix an error in multipart_test (Closed)

Description

Patch Set 1 #

Patch Set 2 : Version .4-dev #

Messages