Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2133113002: Revert of [Payments] Update autofill/payments spacings (Closed)

Created:
4 years, 5 months ago by gsennton
Modified:
4 years, 5 months ago
CC:
chromium-reviews, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Revert of [Payments] Update autofill/payments spacings (patchset #1 id:1 of https://codereview.chromium.org/2130633004/ ) Reason for revert: The ToT version of this patch breaks the Android Tests (dbg) bot, I've filed bug crbug.com/626606 for this issue and reverted that patch (see https://codereview.chromium.org/2137443002). I'm now reverting this patch as well to keep this branch consistent. Original issue's description: > [Payments] Update autofill/payments spacings > > * The fields felt a little squished. Try to space them out a little better. > > * Update the underline colors to match the TextInputLayers. > > * Add support for half width controls in the display. > > Screenshots here: > https://bugs.chromium.org/p/chromium/issues/detail?id=603635#c190 > > BUG=603635, 626451 > TBR=ianwen,rouslan > > Review-Url: https://codereview.chromium.org/2114493002 > Cr-Commit-Position: refs/heads/master@{#404241} > Committed: https://chromium.googlesource.com/chromium/src/+/ff2286219348812bd01cd9c87e58308399143c9a TBR=ianwen@chromium.org,rouslan@chromium.org,dfalcantara@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=603635, 626451

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -247 lines) Patch
M chrome/android/java/res/layout/autofill_billing_address_dropdown.xml View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/android/java/res/layout/autofill_local_card_editor.xml View 5 chunks +14 lines, -27 lines 0 comments Download
M chrome/android/java/res/layout/autofill_profile_editor.xml View 3 chunks +27 lines, -14 lines 0 comments Download
M chrome/android/java/res/layout/autofill_server_card_editor.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/res/layout/payment_request_editor.xml View 1 chunk +14 lines, -3 lines 0 comments Download
D chrome/android/java/res/layout/payment_request_editor_dropdown.xml View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/android/java/res/layout/payment_request_editor_footer.xml View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/android/java/res/layout/preference_address_float_label_layout.xml View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/android/java/res/values-v17/styles.xml View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/res/values-v21/styles.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java View 6 chunks +4 lines, -16 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java View 8 chunks +51 lines, -104 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileEditor.java View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/CompatibilityTextInputLayout.java View 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java View 4 chunks +18 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
gsennton
Created Revert of [Payments] Update autofill/payments spacings
4 years, 5 months ago (2016-07-08 10:17:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133113002/1
4 years, 5 months ago (2016-07-08 10:17:48 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 10:19:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698