Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 2137443002: Revert of [Payments] Update autofill/payments spacings (Closed)

Created:
4 years, 5 months ago by gsennton
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@payments_ongoing
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Payments] Update autofill/payments spacings (patchset #9 id:160001 of https://codereview.chromium.org/2114493002/ ) Reason for revert: This patch breaks the Android Tests (dbg) bot, I've filed bug crbug.com/626606 for this issue. It breaks in C 857.741s Main [FAIL] org.chromium.chrome.browser.payments.PaymentRequestFreeShippingTest#testChangeCountryAddAddressAndPay: C 857.741s Main java.lang.AssertionError C 857.741s Main at org.chromium.chrome.browser.payments.ui.EditorView.addFieldViewToEditor(EditorView.java:293) Original issue's description: > [Payments] Update autofill/payments spacings > > * The fields felt a little squished. Try to space them out a little better. > > * Update the underline colors to match the TextInputLayers. > > * Add support for half width controls in the display. > > Screenshots here: > https://bugs.chromium.org/p/chromium/issues/detail?id=603635#c190 > > BUG=603635, 626451 > > Committed: https://crrev.com/975b62f4fe7cfd7f3de7ab6fc49a3cc20e7f49ce > Cr-Commit-Position: refs/heads/master@{#404241} TBR=rouslan@chromium.org,ianwen@chromium.org,dfalcantara@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=603635, 626451 Committed: https://crrev.com/3c7f3e612cd4abe9153d6429501d4d1c1110a5fb Cr-Commit-Position: refs/heads/master@{#404331}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -247 lines) Patch
M chrome/android/java/res/layout/autofill_billing_address_dropdown.xml View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/android/java/res/layout/autofill_local_card_editor.xml View 5 chunks +14 lines, -27 lines 0 comments Download
M chrome/android/java/res/layout/autofill_profile_editor.xml View 3 chunks +27 lines, -14 lines 0 comments Download
M chrome/android/java/res/layout/autofill_server_card_editor.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/res/layout/payment_request_editor.xml View 1 chunk +14 lines, -3 lines 0 comments Download
D chrome/android/java/res/layout/payment_request_editor_dropdown.xml View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/android/java/res/layout/payment_request_editor_footer.xml View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/android/java/res/layout/preference_address_float_label_layout.xml View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/android/java/res/values-v17/styles.xml View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/res/values-v21/styles.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java View 6 chunks +4 lines, -16 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java View 8 chunks +51 lines, -104 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileEditor.java View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/CompatibilityTextInputLayout.java View 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java View 4 chunks +18 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
gsennton
Created Revert of [Payments] Update autofill/payments spacings
4 years, 5 months ago (2016-07-08 09:38:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137443002/1
4 years, 5 months ago (2016-07-08 09:38:45 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 09:40:13 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3c7f3e612cd4abe9153d6429501d4d1c1110a5fb Cr-Commit-Position: refs/heads/master@{#404331}
4 years, 5 months ago (2016-07-08 09:42:53 UTC) #7
please use gerrit instead
4 years, 5 months ago (2016-07-08 10:02:13 UTC) #8
Message was sent while issue was closed.
dfalcantara@, you need to run removeTextChangedListenerFromPhoneInputField() at
the top of the prepareEditor(). This will clear the old state and fix the
assertion. Then you can reland this patch.

Powered by Google App Engine
This is Rietveld 408576698