chrome/browser/ui/toolbar/app_menu_model.h - Issue 2133013002: AcceleratorProvider: Make GetAcceleratorForCommandId const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/app_menu_model.h

Issue 2133013002: AcceleratorProvider: Make GetAcceleratorForCommandId const. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix overrides on Mac and Chrome OS. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/toolbar/app_menu_model.h

diff --git a/chrome/browser/ui/toolbar/app_menu_model.h b/chrome/browser/ui/toolbar/app_menu_model.h

index 11afa0c808fc19d072977dabaad560f80f865eae..963491541e41e685c7baafdcbf9ab83e9a184868 100644

--- a/chrome/browser/ui/toolbar/app_menu_model.h

+++ b/chrome/browser/ui/toolbar/app_menu_model.h

@@ -86,7 +86,7 @@ class EncodingMenuModel : public ui::SimpleMenuModel,

bool IsCommandIdChecked(int command_id) const override;

bool IsCommandIdEnabled(int command_id) const override;

bool GetAcceleratorForCommandId(int command_id,

- ui::Accelerator* accelerator) override;

+ ui::Accelerator* accelerator) const override;

void ExecuteCommand(int command_id, int event_flags) override;

private:

@@ -148,7 +148,7 @@ class AppMenuModel : public ui::SimpleMenuModel,

bool IsCommandIdEnabled(int command_id) const override;

bool IsCommandIdVisible(int command_id) const override;

bool GetAcceleratorForCommandId(int command_id,

- ui::Accelerator* accelerator) override;

+ ui::Accelerator* accelerator) const override;

// Overridden from TabStripModelObserver:

void ActiveTabChanged(content::WebContents* old_contents,

« no previous file with comments | « chrome/browser/ui/panels/panel_extension_browsertest.cc ('k') | chrome/browser/ui/toolbar/app_menu_model.cc » ('j') | no next file with comments »