chrome/browser/ui/toolbar/app_menu_model.cc - Issue 2133013002: AcceleratorProvider: Make GetAcceleratorForCommandId const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/app_menu_model.cc

Issue 2133013002: AcceleratorProvider: Make GetAcceleratorForCommandId const. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix overrides on Mac and Chrome OS. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/toolbar/app_menu_model.cc

diff --git a/chrome/browser/ui/toolbar/app_menu_model.cc b/chrome/browser/ui/toolbar/app_menu_model.cc

index 19f6fefd58b1a9a4405f3eb982668381449f4298..9209ab16890b176ea27fe20b90b14ae227f1500e 100644

--- a/chrome/browser/ui/toolbar/app_menu_model.cc

+++ b/chrome/browser/ui/toolbar/app_menu_model.cc

@@ -171,7 +171,7 @@ bool EncodingMenuModel::IsCommandIdEnabled(int command_id) const {

bool EncodingMenuModel::GetAcceleratorForCommandId(

int command_id,

- ui::Accelerator* accelerator) {

+ ui::Accelerator* accelerator) const {

return false;

}

@@ -721,8 +721,9 @@ bool AppMenuModel::IsCommandIdVisible(int command_id) const {

}

-bool AppMenuModel::GetAcceleratorForCommandId(int command_id,

- ui::Accelerator* accelerator) {

+bool AppMenuModel::GetAcceleratorForCommandId(

+ int command_id,

+ ui::Accelerator* accelerator) const {

return provider_->GetAcceleratorForCommandId(command_id, accelerator);

}

« no previous file with comments | « chrome/browser/ui/toolbar/app_menu_model.h ('k') | chrome/browser/ui/toolbar/app_menu_model_unittest.cc » ('j') | no next file with comments »