Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issue 2132993002: Fix initialization of udev in MidiManagerAlsa. (Closed)

Created:
4 years, 5 months ago by Takashi Toyoshima
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Fix initialization of udev in MidiManagerAlsa. New devices would not be detected on Linux. Worse, things would get very confused if you disconnected one device and connected another. This has been broken for four months, with crrev.com/17cd1b10ded3a5e730bbcb39c57a6d2f8e16a51e BUG=625123 Review-Url: https://codereview.chromium.org/2126023004 Cr-Commit-Position: refs/heads/master@{#404092} (cherry picked from commit e74c2a9687c28f2718d71ae6ad9b6153119361c7) TBR=agoode@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/279c20325144a6b9a024d4c70e7b3f7417d8f80f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/midi/midi_manager_alsa.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (2 generated)
Takashi Toyoshima
4 years, 5 months ago (2016-07-08 06:12:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
279c20325144a6b9a024d4c70e7b3f7417d8f80f (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698