Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Unified Diff: runtime/vm/assembler_x64_test.cc

Issue 2132933003: VM: Remove collection of unused range feedback. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: remove comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_x64.cc ('k') | runtime/vm/il_printer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_x64_test.cc
diff --git a/runtime/vm/assembler_x64_test.cc b/runtime/vm/assembler_x64_test.cc
index eb8219d9d982186e4f4ae7c7c1c2462ec7afd4fb..681a5997dea57b2d4097171f45d326c91d411ff1 100644
--- a/runtime/vm/assembler_x64_test.cc
+++ b/runtime/vm/assembler_x64_test.cc
@@ -3589,55 +3589,6 @@ ASSEMBLER_TEST_RUN(ConditionalMovesNoOverflow, test) {
EXPECT_EQ(0, res);
}
-
-ASSEMBLER_TEST_GENERATE(ComputeRange, assembler) {
- Label miss;
- __ movq(RDX, CallingConventions::kArg1Reg);
- __ ComputeRange(RAX, RDX, &miss);
- __ ret();
-
- __ Bind(&miss);
- __ movq(RAX, Immediate(0));
- __ ret();
-}
-
-
-ASSEMBLER_TEST_RUN(ComputeRange, test) {
- typedef intptr_t (*ComputeRange)(RawObject*);
- ComputeRange range_of = reinterpret_cast<ComputeRange>(test->entry());
-
- EXPECT_EQ(ICData::kInt32RangeBit, range_of(Smi::New(0)));
- EXPECT_EQ(ICData::kInt32RangeBit, range_of(Smi::New(1)));
- EXPECT_EQ(ICData::kInt32RangeBit, range_of(Smi::New(kMaxInt32)));
- EXPECT_EQ(ICData::kInt32RangeBit | ICData::kSignedRangeBit,
- range_of(Smi::New(-1)));
- EXPECT_EQ(ICData::kInt32RangeBit | ICData::kSignedRangeBit,
- range_of(Smi::New(kMinInt32)));
-
- EXPECT_EQ(ICData::kUint32RangeBit,
- range_of(Smi::New(static_cast<int64_t>(kMaxInt32) + 1)));
- EXPECT_EQ(ICData::kUint32RangeBit,
- range_of(Smi::New(kMaxUint32)));
-
- // On 64-bit platforms we don't track the sign of the smis outside of
- // int32 range because it is not needed to distinguish kInt32Range from
- // kUint32Range.
- EXPECT_EQ(ICData::kSignedRangeBit,
- range_of(Smi::New(static_cast<int64_t>(kMinInt32) - 1)));
- EXPECT_EQ(ICData::kSignedRangeBit,
- range_of(Smi::New(static_cast<int64_t>(kMaxUint32) + 1)));
- EXPECT_EQ(ICData::kSignedRangeBit, range_of(Smi::New(Smi::kMaxValue)));
- EXPECT_EQ(ICData::kSignedRangeBit, range_of(Smi::New(Smi::kMinValue)));
-
- EXPECT_EQ(ICData::kInt64RangeBit, range_of(Integer::New(Smi::kMaxValue + 1)));
- EXPECT_EQ(ICData::kInt64RangeBit, range_of(Integer::New(Smi::kMinValue - 1)));
- EXPECT_EQ(ICData::kInt64RangeBit, range_of(Integer::New(kMaxInt64)));
- EXPECT_EQ(ICData::kInt64RangeBit, range_of(Integer::New(kMinInt64)));
-
- EXPECT_EQ(0, range_of(Bool::True().raw()));
-}
-
-
} // namespace dart
#endif // defined TARGET_ARCH_X64
« no previous file with comments | « runtime/vm/assembler_x64.cc ('k') | runtime/vm/il_printer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698