Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: runtime/vm/assembler_ia32_test.cc

Issue 2132933003: VM: Remove collection of unused range feedback. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: remove comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_ia32.cc ('k') | runtime/vm/assembler_mips.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_ia32_test.cc
diff --git a/runtime/vm/assembler_ia32_test.cc b/runtime/vm/assembler_ia32_test.cc
index 2ce9da22a365b1152ef548150ebd62d2f064891f..116cc9e35beb9505a7fa1a2c3469a3c29bedcb89 100644
--- a/runtime/vm/assembler_ia32_test.cc
+++ b/runtime/vm/assembler_ia32_test.cc
@@ -3425,58 +3425,6 @@ ASSEMBLER_TEST_RUN(BitTest, test) {
EXPECT_EQ(1, reinterpret_cast<BitTest>(test->entry())());
}
-
-ASSEMBLER_TEST_GENERATE(ComputeRange, assembler) {
- Label miss, done;
- __ movl(ECX, Address(ESP, 1 * kWordSize));
-
- __ pushl(ESI);
- __ pushl(EDI);
- __ ComputeRange(EAX, ECX, ESI, EDI, &miss);
- __ jmp(&done);
-
- __ Bind(&miss);
- __ movl(EAX, Immediate(-1));
-
- __ Bind(&done);
- __ popl(EDI);
- __ popl(ESI);
- __ ret();
-}
-
-
-ASSEMBLER_TEST_RUN(ComputeRange, test) {
- typedef intptr_t (*ComputeRange)(RawObject* value);
- ComputeRange range_of = reinterpret_cast<ComputeRange>(test->entry());
-
- EXPECT_EQ(0, range_of(Smi::New(0)));
- EXPECT_EQ(0, range_of(Smi::New(1)));
- EXPECT_EQ(ICData::kSignedRangeBit, range_of(Smi::New(-1)));
- EXPECT_EQ(0, range_of(Smi::New(Smi::kMaxValue)));
- EXPECT_EQ(ICData::kSignedRangeBit, range_of(Smi::New(Smi::kMinValue)));
-
- EXPECT_EQ(ICData::kInt32RangeBit, range_of(Integer::New(Smi::kMaxValue + 1)));
- EXPECT_EQ(ICData::kInt32RangeBit | ICData::kSignedRangeBit,
- range_of(Integer::New(Smi::kMinValue - 1)));
- EXPECT_EQ(ICData::kInt32RangeBit, range_of(Integer::New(kMaxInt32)));
- EXPECT_EQ(ICData::kInt32RangeBit | ICData::kSignedRangeBit,
- range_of(Integer::New(kMinInt32)));
-
- EXPECT_EQ(ICData::kUint32RangeBit,
- range_of(Integer::New(static_cast<int64_t>(kMaxInt32) + 1)));
- EXPECT_EQ(ICData::kUint32RangeBit, range_of(Integer::New(kMaxUint32)));
-
- EXPECT_EQ(ICData::kInt64RangeBit,
- range_of(Integer::New(static_cast<int64_t>(kMaxUint32) + 1)));
- EXPECT_EQ(ICData::kInt64RangeBit,
- range_of(Integer::New(static_cast<int64_t>(kMinInt32) - 1)));
- EXPECT_EQ(ICData::kInt64RangeBit, range_of(Integer::New(kMaxInt64)));
- EXPECT_EQ(ICData::kInt64RangeBit, range_of(Integer::New(kMinInt64)));
-
- EXPECT_EQ(-1, range_of(Bool::True().raw()));
-}
-
-
} // namespace dart
#endif // defined TARGET_ARCH_IA32
« no previous file with comments | « runtime/vm/assembler_ia32.cc ('k') | runtime/vm/assembler_mips.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698