Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1359)

Unified Diff: net/quic/crypto/proof_verifier_chromium.cc

Issue 2132623002: Landing Recent QUIC changes until 2016-07-02 02:45 UTC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing comment about RPCs Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/crypto/proof_verifier_chromium.h ('k') | net/quic/crypto/proof_verifier_chromium_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/crypto/proof_verifier_chromium.cc
diff --git a/net/quic/crypto/proof_verifier_chromium.cc b/net/quic/crypto/proof_verifier_chromium.cc
index 096374a747255b451000cf3afccf034083a13368..621eb1f912ae6c21308f27423f021daaa64e62cf 100644
--- a/net/quic/crypto/proof_verifier_chromium.cc
+++ b/net/quic/crypto/proof_verifier_chromium.cc
@@ -76,7 +76,7 @@ class ProofVerifierChromium::Job {
const std::string& signature,
std::string* error_details,
std::unique_ptr<ProofVerifyDetails>* verify_details,
- ProofVerifierCallback* callback);
+ std::unique_ptr<ProofVerifierCallback> callback);
private:
enum State {
@@ -180,7 +180,7 @@ QuicAsyncStatus ProofVerifierChromium::Job::VerifyProof(
const string& signature,
std::string* error_details,
std::unique_ptr<ProofVerifyDetails>* verify_details,
- ProofVerifierCallback* callback) {
+ std::unique_ptr<ProofVerifierCallback> callback) {
DCHECK(error_details);
DCHECK(verify_details);
DCHECK(callback);
@@ -246,7 +246,7 @@ QuicAsyncStatus ProofVerifierChromium::Job::VerifyProof(
*verify_details = std::move(verify_details_);
return QUIC_SUCCESS;
case ERR_IO_PENDING:
- callback_.reset(callback);
+ callback_ = std::move(callback);
return QUIC_PENDING;
default:
*error_details = error_details_;
@@ -491,7 +491,7 @@ QuicAsyncStatus ProofVerifierChromium::VerifyProof(
const ProofVerifyContext* verify_context,
std::string* error_details,
std::unique_ptr<ProofVerifyDetails>* verify_details,
- ProofVerifierCallback* callback) {
+ std::unique_ptr<ProofVerifierCallback> callback) {
if (!verify_context) {
*error_details = "Missing context";
return QUIC_FAILURE;
@@ -504,7 +504,7 @@ QuicAsyncStatus ProofVerifierChromium::VerifyProof(
chromium_context->cert_verify_flags, chromium_context->net_log));
QuicAsyncStatus status = job->VerifyProof(
hostname, port, server_config, quic_version, chlo_hash, certs, cert_sct,
- signature, error_details, verify_details, callback);
+ signature, error_details, verify_details, std::move(callback));
if (status == QUIC_PENDING) {
active_jobs_.insert(job.release());
}
« no previous file with comments | « net/quic/crypto/proof_verifier_chromium.h ('k') | net/quic/crypto/proof_verifier_chromium_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698