Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1360)

Unified Diff: net/quic/crypto/proof_verifier_chromium_test.cc

Issue 2132623002: Landing Recent QUIC changes until 2016-07-02 02:45 UTC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing comment about RPCs Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/crypto/proof_verifier_chromium.cc ('k') | net/quic/crypto/quic_crypto_client_config.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/crypto/proof_verifier_chromium_test.cc
diff --git a/net/quic/crypto/proof_verifier_chromium_test.cc b/net/quic/crypto/proof_verifier_chromium_test.cc
index ba881c6285b0fb43b63f5756d43765c8a1e2225f..fff1bf6d6b28203273945d02f028c67b126e1b39 100644
--- a/net/quic/crypto/proof_verifier_chromium_test.cc
+++ b/net/quic/crypto/proof_verifier_chromium_test.cc
@@ -233,7 +233,7 @@ TEST_F(ProofVerifierChromiumTest, FailsIfCertFails) {
QuicAsyncStatus status = proof_verifier.VerifyProof(
kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_, "",
GetTestSignature(), verify_context_.get(), &error_details_, &details_,
- callback.get());
+ std::move(callback));
ASSERT_EQ(QUIC_FAILURE, status);
}
@@ -252,7 +252,7 @@ TEST_F(ProofVerifierChromiumTest, ValidSCTList) {
QuicAsyncStatus status = proof_verifier.VerifyProof(
kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_,
ct::GetSCTListForTesting(), "", verify_context_.get(), &error_details_,
- &details_, callback.get());
+ &details_, std::move(callback));
ASSERT_EQ(QUIC_FAILURE, status);
CheckSCT(/*sct_expected_ok=*/true);
}
@@ -272,7 +272,7 @@ TEST_F(ProofVerifierChromiumTest, InvalidSCTList) {
QuicAsyncStatus status = proof_verifier.VerifyProof(
kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_,
ct::GetSCTListWithInvalidSCT(), "", verify_context_.get(),
- &error_details_, &details_, callback.get());
+ &error_details_, &details_, std::move(callback));
ASSERT_EQ(QUIC_FAILURE, status);
CheckSCT(/*sct_expected_ok=*/false);
}
@@ -290,7 +290,7 @@ TEST_F(ProofVerifierChromiumTest, FailsIfSignatureFails) {
QuicAsyncStatus status = proof_verifier.VerifyProof(
kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_, "",
kTestConfig, verify_context_.get(), &error_details_, &details_,
- callback.get());
+ std::move(callback));
ASSERT_EQ(QUIC_FAILURE, status);
}
@@ -320,7 +320,7 @@ TEST_F(ProofVerifierChromiumTest, PreservesEVIfAllowed) {
QuicAsyncStatus status = proof_verifier.VerifyProof(
kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_, "",
GetTestSignature(), verify_context_.get(), &error_details_, &details_,
- callback.get());
+ std::move(callback));
ASSERT_EQ(QUIC_SUCCESS, status);
ASSERT_TRUE(details_.get());
@@ -356,7 +356,7 @@ TEST_F(ProofVerifierChromiumTest, StripsEVIfNotAllowed) {
QuicAsyncStatus status = proof_verifier.VerifyProof(
kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_, "",
GetTestSignature(), verify_context_.get(), &error_details_, &details_,
- callback.get());
+ std::move(callback));
ASSERT_EQ(QUIC_SUCCESS, status);
ASSERT_TRUE(details_.get());
@@ -391,7 +391,7 @@ TEST_F(ProofVerifierChromiumTest, IgnoresPolicyEnforcerIfNotEV) {
QuicAsyncStatus status = proof_verifier.VerifyProof(
kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_, "",
GetTestSignature(), verify_context_.get(), &error_details_, &details_,
- callback.get());
+ std::move(callback));
ASSERT_EQ(QUIC_SUCCESS, status);
ASSERT_TRUE(details_.get());
@@ -436,7 +436,7 @@ TEST_F(ProofVerifierChromiumTest, PKPEnforced) {
QuicAsyncStatus status = proof_verifier.VerifyProof(
kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_, "",
GetTestSignature(), verify_context_.get(), &error_details_, &details_,
- callback.get());
+ std::move(callback));
ASSERT_EQ(QUIC_FAILURE, status);
ASSERT_TRUE(details_.get());
@@ -477,7 +477,7 @@ TEST_F(ProofVerifierChromiumTest, PKPBypassFlagSet) {
QuicAsyncStatus status = proof_verifier.VerifyProof(
kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_, "",
GetTestSignature(), verify_context_.get(), &error_details_, &details_,
- callback.get());
+ std::move(callback));
ASSERT_EQ(QUIC_SUCCESS, status);
ASSERT_TRUE(details_.get());
@@ -523,7 +523,7 @@ TEST_F(ProofVerifierChromiumTest, CTIsRequired) {
QuicAsyncStatus status = proof_verifier.VerifyProof(
kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_, "",
GetTestSignature(), verify_context_.get(), &error_details_, &details_,
- callback.get());
+ std::move(callback));
ASSERT_EQ(QUIC_FAILURE, status);
ASSERT_TRUE(details_.get());
@@ -575,7 +575,7 @@ TEST_F(ProofVerifierChromiumTest, PKPAndCTBothTested) {
QuicAsyncStatus status = proof_verifier.VerifyProof(
kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_25, "", certs_, "",
GetTestSignature(), verify_context_.get(), &error_details_, &details_,
- callback.get());
+ std::move(callback));
ASSERT_EQ(QUIC_FAILURE, status);
ASSERT_TRUE(details_.get());
« no previous file with comments | « net/quic/crypto/proof_verifier_chromium.cc ('k') | net/quic/crypto/quic_crypto_client_config.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698