Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4531)

Unified Diff: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc

Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nasko@ nits Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
index 8a1c61778cea6c80335479cb87a829bb7e7bd233..325a16980ce94e45854009f1129032459a7400a1 100644
--- a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
@@ -21,31 +21,49 @@ class AbortsPageLoadMetricsObserverTest
}
};
-TEST_F(AbortsPageLoadMetricsObserverTest, UnknownNavigationBeforeCommit) {
+TEST_F(AbortsPageLoadMetricsObserverTest, NewNavigationBeforeCommit) {
StartNavigation(GURL("https://www.google.com"));
// Simulate the user performing another navigation before commit.
NavigateAndCommit(GURL("https://www.example.com"));
histogram_tester().ExpectTotalCount(
- internal::kHistogramAbortUnknownNavigationBeforeCommit, 1);
+ internal::kHistogramAbortNewNavigationBeforeCommit, 1);
+}
+
+TEST_F(AbortsPageLoadMetricsObserverTest, ReloadBeforeCommit) {
+ StartNavigation(GURL("https://www.google.com"));
+ // Simulate the user performing another navigation before commit.
+ NavigateWithPageTransitionAndCommit(GURL("https://www.example.com"),
+ ui::PAGE_TRANSITION_RELOAD);
+ histogram_tester().ExpectTotalCount(
+ internal::kHistogramAbortReloadBeforeCommit, 1);
+}
+
+TEST_F(AbortsPageLoadMetricsObserverTest, ForwardBackBeforeCommit) {
+ StartNavigation(GURL("https://www.google.com"));
+ // Simulate the user performing another navigation before commit.
+ NavigateWithPageTransitionAndCommit(GURL("https://www.example.com"),
+ ui::PAGE_TRANSITION_FORWARD_BACK);
+ histogram_tester().ExpectTotalCount(
+ internal::kHistogramAbortForwardBackBeforeCommit, 1);
}
TEST_F(AbortsPageLoadMetricsObserverTest,
- UnknownProvisionalNavigationBeforeCommit) {
+ NewProvisionalNavigationBeforeCommit) {
StartNavigation(GURL("https://www.google.com"));
StartNavigation(GURL("https://www.example.com"));
histogram_tester().ExpectTotalCount(
- internal::kHistogramAbortUnknownNavigationBeforeCommit, 1);
+ internal::kHistogramAbortNewNavigationBeforeCommit, 1);
}
TEST_F(AbortsPageLoadMetricsObserverTest,
- UnknownNavigationBeforeCommitNonTrackedPageLoad) {
+ NewNavigationBeforeCommitNonTrackedPageLoad) {
StartNavigation(GURL("https://www.google.com"));
// Simulate the user performing another navigation before commit. Navigate to
// an untracked URL, to verify that we still log abort metrics even if the new
// navigation isn't tracked.
NavigateAndCommit(GURL("about:blank"));
histogram_tester().ExpectTotalCount(
- internal::kHistogramAbortUnknownNavigationBeforeCommit, 1);
+ internal::kHistogramAbortNewNavigationBeforeCommit, 1);
}
TEST_F(AbortsPageLoadMetricsObserverTest, NewNavigationBeforePaint) {

Powered by Google App Engine
This is Rietveld 408576698