Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2341)

Unified Diff: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc

Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nasko@ nits Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
index 786e31044e49e037f429c8a498864d927fa1a1eb..28e31d04413049ce5fb4bfdc0e95816a70c4d9c2 100644
--- a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
@@ -22,8 +22,6 @@ const char kHistogramAbortCloseBeforeCommit[] =
"PageLoad.AbortTiming.Close.BeforeCommit";
const char kHistogramAbortOtherBeforeCommit[] =
"PageLoad.AbortTiming.Other.BeforeCommit";
-const char kHistogramAbortUnknownNavigationBeforeCommit[] =
- "PageLoad.AbortTiming.UnknownNavigation.BeforeCommit";
const char kHistogramAbortForwardBackBeforePaint[] =
"PageLoad.AbortTiming.ForwardBackNavigation.AfterCommit.BeforePaint";
@@ -78,11 +76,6 @@ void RecordAbortBeforeCommit(UserAbortType abort_type,
PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortOtherBeforeCommit,
time_to_abort);
return;
- case UserAbortType::ABORT_UNKNOWN_NAVIGATION:
- PAGE_LOAD_HISTOGRAM(
- internal::kHistogramAbortUnknownNavigationBeforeCommit,
- time_to_abort);
- return;
case UserAbortType::ABORT_NONE:
case UserAbortType::ABORT_LAST_ENTRY:
NOTREACHED();
@@ -114,10 +107,6 @@ void RecordAbortAfterCommitBeforePaint(UserAbortType abort_type,
PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortCloseBeforePaint,
time_to_abort);
return;
- case UserAbortType::ABORT_UNKNOWN_NAVIGATION:
- NOTREACHED() << "Received UserAbortType::ABORT_UNKNOWN_NAVIGATION for "
- "committed load.";
- return;
case UserAbortType::ABORT_OTHER:
NOTREACHED() << "Received UserAbortType::ABORT_OTHER for committed load.";
return;
@@ -152,10 +141,6 @@ void RecordAbortDuringParse(UserAbortType abort_type,
PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortCloseDuringParse,
time_to_abort);
return;
- case UserAbortType::ABORT_UNKNOWN_NAVIGATION:
- NOTREACHED() << "Received UserAbortType::ABORT_UNKNOWN_NAVIGATION for "
- "committed load.";
- return;
case UserAbortType::ABORT_OTHER:
NOTREACHED() << "Received UserAbortType::ABORT_OTHER for committed load.";
return;

Powered by Google App Engine
This is Rietveld 408576698