Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc

Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nasko@ nits Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h" 5 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h"
6 6
7 #include "chrome/browser/page_load_metrics/page_load_metrics_util.h" 7 #include "chrome/browser/page_load_metrics/page_load_metrics_util.h"
8 8
9 using page_load_metrics::UserAbortType; 9 using page_load_metrics::UserAbortType;
10 10
11 namespace internal { 11 namespace internal {
12 12
13 const char kHistogramAbortForwardBackBeforeCommit[] = 13 const char kHistogramAbortForwardBackBeforeCommit[] =
14 "PageLoad.AbortTiming.ForwardBackNavigation.BeforeCommit"; 14 "PageLoad.AbortTiming.ForwardBackNavigation.BeforeCommit";
15 const char kHistogramAbortReloadBeforeCommit[] = 15 const char kHistogramAbortReloadBeforeCommit[] =
16 "PageLoad.AbortTiming.Reload.BeforeCommit"; 16 "PageLoad.AbortTiming.Reload.BeforeCommit";
17 const char kHistogramAbortNewNavigationBeforeCommit[] = 17 const char kHistogramAbortNewNavigationBeforeCommit[] =
18 "PageLoad.AbortTiming.NewNavigation.BeforeCommit"; 18 "PageLoad.AbortTiming.NewNavigation.BeforeCommit";
19 const char kHistogramAbortStopBeforeCommit[] = 19 const char kHistogramAbortStopBeforeCommit[] =
20 "PageLoad.AbortTiming.Stop.BeforeCommit"; 20 "PageLoad.AbortTiming.Stop.BeforeCommit";
21 const char kHistogramAbortCloseBeforeCommit[] = 21 const char kHistogramAbortCloseBeforeCommit[] =
22 "PageLoad.AbortTiming.Close.BeforeCommit"; 22 "PageLoad.AbortTiming.Close.BeforeCommit";
23 const char kHistogramAbortOtherBeforeCommit[] = 23 const char kHistogramAbortOtherBeforeCommit[] =
24 "PageLoad.AbortTiming.Other.BeforeCommit"; 24 "PageLoad.AbortTiming.Other.BeforeCommit";
25 const char kHistogramAbortUnknownNavigationBeforeCommit[] =
26 "PageLoad.AbortTiming.UnknownNavigation.BeforeCommit";
27 25
28 const char kHistogramAbortForwardBackBeforePaint[] = 26 const char kHistogramAbortForwardBackBeforePaint[] =
29 "PageLoad.AbortTiming.ForwardBackNavigation.AfterCommit.BeforePaint"; 27 "PageLoad.AbortTiming.ForwardBackNavigation.AfterCommit.BeforePaint";
30 const char kHistogramAbortReloadBeforePaint[] = 28 const char kHistogramAbortReloadBeforePaint[] =
31 "PageLoad.AbortTiming.Reload.AfterCommit.BeforePaint"; 29 "PageLoad.AbortTiming.Reload.AfterCommit.BeforePaint";
32 const char kHistogramAbortNewNavigationBeforePaint[] = 30 const char kHistogramAbortNewNavigationBeforePaint[] =
33 "PageLoad.AbortTiming.NewNavigation.AfterCommit.BeforePaint"; 31 "PageLoad.AbortTiming.NewNavigation.AfterCommit.BeforePaint";
34 const char kHistogramAbortStopBeforePaint[] = 32 const char kHistogramAbortStopBeforePaint[] =
35 "PageLoad.AbortTiming.Stop.AfterCommit.BeforePaint"; 33 "PageLoad.AbortTiming.Stop.AfterCommit.BeforePaint";
36 const char kHistogramAbortCloseBeforePaint[] = 34 const char kHistogramAbortCloseBeforePaint[] =
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 time_to_abort); 69 time_to_abort);
72 return; 70 return;
73 case UserAbortType::ABORT_CLOSE: 71 case UserAbortType::ABORT_CLOSE:
74 PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortCloseBeforeCommit, 72 PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortCloseBeforeCommit,
75 time_to_abort); 73 time_to_abort);
76 return; 74 return;
77 case UserAbortType::ABORT_OTHER: 75 case UserAbortType::ABORT_OTHER:
78 PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortOtherBeforeCommit, 76 PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortOtherBeforeCommit,
79 time_to_abort); 77 time_to_abort);
80 return; 78 return;
81 case UserAbortType::ABORT_UNKNOWN_NAVIGATION:
82 PAGE_LOAD_HISTOGRAM(
83 internal::kHistogramAbortUnknownNavigationBeforeCommit,
84 time_to_abort);
85 return;
86 case UserAbortType::ABORT_NONE: 79 case UserAbortType::ABORT_NONE:
87 case UserAbortType::ABORT_LAST_ENTRY: 80 case UserAbortType::ABORT_LAST_ENTRY:
88 NOTREACHED(); 81 NOTREACHED();
89 return; 82 return;
90 } 83 }
91 NOTREACHED(); 84 NOTREACHED();
92 } 85 }
93 86
94 void RecordAbortAfterCommitBeforePaint(UserAbortType abort_type, 87 void RecordAbortAfterCommitBeforePaint(UserAbortType abort_type,
95 base::TimeDelta time_to_abort) { 88 base::TimeDelta time_to_abort) {
(...skipping 11 matching lines...) Expand all
107 time_to_abort); 100 time_to_abort);
108 return; 101 return;
109 case UserAbortType::ABORT_STOP: 102 case UserAbortType::ABORT_STOP:
110 PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortStopBeforePaint, 103 PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortStopBeforePaint,
111 time_to_abort); 104 time_to_abort);
112 return; 105 return;
113 case UserAbortType::ABORT_CLOSE: 106 case UserAbortType::ABORT_CLOSE:
114 PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortCloseBeforePaint, 107 PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortCloseBeforePaint,
115 time_to_abort); 108 time_to_abort);
116 return; 109 return;
117 case UserAbortType::ABORT_UNKNOWN_NAVIGATION:
118 NOTREACHED() << "Received UserAbortType::ABORT_UNKNOWN_NAVIGATION for "
119 "committed load.";
120 return;
121 case UserAbortType::ABORT_OTHER: 110 case UserAbortType::ABORT_OTHER:
122 NOTREACHED() << "Received UserAbortType::ABORT_OTHER for committed load."; 111 NOTREACHED() << "Received UserAbortType::ABORT_OTHER for committed load.";
123 return; 112 return;
124 case UserAbortType::ABORT_NONE: 113 case UserAbortType::ABORT_NONE:
125 case UserAbortType::ABORT_LAST_ENTRY: 114 case UserAbortType::ABORT_LAST_ENTRY:
126 NOTREACHED(); 115 NOTREACHED();
127 return; 116 return;
128 } 117 }
129 NOTREACHED(); 118 NOTREACHED();
130 } 119 }
(...skipping 14 matching lines...) Expand all
145 time_to_abort); 134 time_to_abort);
146 return; 135 return;
147 case UserAbortType::ABORT_STOP: 136 case UserAbortType::ABORT_STOP:
148 PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortStopDuringParse, 137 PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortStopDuringParse,
149 time_to_abort); 138 time_to_abort);
150 return; 139 return;
151 case UserAbortType::ABORT_CLOSE: 140 case UserAbortType::ABORT_CLOSE:
152 PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortCloseDuringParse, 141 PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortCloseDuringParse,
153 time_to_abort); 142 time_to_abort);
154 return; 143 return;
155 case UserAbortType::ABORT_UNKNOWN_NAVIGATION:
156 NOTREACHED() << "Received UserAbortType::ABORT_UNKNOWN_NAVIGATION for "
157 "committed load.";
158 return;
159 case UserAbortType::ABORT_OTHER: 144 case UserAbortType::ABORT_OTHER:
160 NOTREACHED() << "Received UserAbortType::ABORT_OTHER for committed load."; 145 NOTREACHED() << "Received UserAbortType::ABORT_OTHER for committed load.";
161 return; 146 return;
162 case UserAbortType::ABORT_NONE: 147 case UserAbortType::ABORT_NONE:
163 case UserAbortType::ABORT_LAST_ENTRY: 148 case UserAbortType::ABORT_LAST_ENTRY:
164 NOTREACHED(); 149 NOTREACHED();
165 return; 150 return;
166 } 151 }
167 NOTREACHED(); 152 NOTREACHED();
168 } 153 }
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 200
216 void AbortsPageLoadMetricsObserver::OnFailedProvisionalLoad( 201 void AbortsPageLoadMetricsObserver::OnFailedProvisionalLoad(
217 const page_load_metrics::FailedProvisionalLoadInfo& failed_load_info, 202 const page_load_metrics::FailedProvisionalLoadInfo& failed_load_info,
218 const page_load_metrics::PageLoadExtraInfo& extra_info) { 203 const page_load_metrics::PageLoadExtraInfo& extra_info) {
219 if (!ShouldTrackMetrics(extra_info)) 204 if (!ShouldTrackMetrics(extra_info))
220 return; 205 return;
221 206
222 RecordAbortBeforeCommit(extra_info.abort_type, 207 RecordAbortBeforeCommit(extra_info.abort_type,
223 extra_info.time_to_abort.value()); 208 extra_info.time_to_abort.value());
224 } 209 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698