chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc - Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Attach the throttle first so it gets all notifications before any DEFERs Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc ('k') | chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc » ('j') | content/public/test/browser_test_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

diff --git a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

index 6bc19602219b1ff130654d4e66a04eb69e6c7dbe..654d1121bb3fd2e066dae5925d1b09cc3eb5ce98 100644

--- a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

+++ b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

@@ -147,11 +147,7 @@ void PageLoadMetricsObserverTestHarness::NavigateWithPageTransitionAndCommit(

const GURL& url,

ui::PageTransition transition) {

controller().LoadURL(url, content::Referrer(), transition, std::string());

- int pending_id = controller().GetPendingEntry()->GetUniqueID();

- const bool did_create_new_entry = true;

- content::WebContentsTester::For(web_contents())

- ->TestDidNavigate(web_contents()->GetMainFrame(), 1, pending_id,

- did_create_new_entry, url, transition);

+ content::WebContentsTester::For(web_contents())->CommitPendingNavigation();

}

} // namespace page_load_metrics