chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc - Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc

Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Attach the throttle first so it gets all notifications before any DEFERs Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc » ('j') | content/public/test/browser_test_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc

index 6618e72ec55f5482d114c2c35d7e0a1b03bb2225..3224ac84880020562511bdfd6325d6f2158be40d 100644

--- a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc

@@ -443,14 +443,14 @@ TEST_F(FromGWSPageLoadMetricsObserverTest,

}

-TEST_F(FromGWSPageLoadMetricsObserverTest, UnknownNavigationBeforeCommit) {

+TEST_F(FromGWSPageLoadMetricsObserverTest, NewNavigationBeforeCommit) {

NavigateAndCommit(GURL(kGoogleSearchResultsUrl));

StartNavigation(GURL("http://example.test"));

// Simulate the user performing another navigation before commit.

- StartNavigation(GURL("https://www.example.com"));

+ NavigateAndCommit(GURL("https://www.example.com"));

histogram_tester().ExpectTotalCount(

- internal::kHistogramFromGWSAbortUnknownNavigationBeforeCommit, 1);

+ internal::kHistogramFromGWSAbortNewNavigationBeforeCommit, 1);

}

TEST_F(FromGWSPageLoadMetricsObserverTest, NewNavigationBeforePaint) {