chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h - Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Attach the throttle first so it gets all notifications before any DEFERs Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc ('k') | chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc » ('j') | content/public/test/browser_test_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

index 0e92752962753442f83822087d1740a532656016..b74399fbb0ac8f43fbd03412943e979b3e08c50c 100644

--- a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

@@ -27,10 +27,10 @@ extern const char kHistogramFromGWSAbortStopBeforeCommit[];

extern const char kHistogramFromGWSAbortCloseBeforePaint[];

extern const char kHistogramFromGWSAbortCloseBeforeInteraction[];

extern const char kHistogramFromGWSAbortCloseBeforeCommit[];

+extern const char kHistogramFromGWSAbortNewNavigationBeforeCommit[];

extern const char kHistogramFromGWSAbortNewNavigationBeforePaint[];

extern const char kHistogramFromGWSAbortNewNavigationBeforeInteraction[];

extern const char kHistogramFromGWSAbortReloadBeforeInteraction[];

-extern const char kHistogramFromGWSAbortUnknownNavigationBeforeCommit[];

} // namespace internal