chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc - Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Attach the throttle first so it gets all notifications before any DEFERs Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc ('k') | chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h » ('j') | content/public/test/browser_test_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

index c19a027f0b3bc26ba61c5e9898dad4d45df62749..b7463fbda2f83496c17e75ce2c3aed44ab097555 100644

--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

@@ -336,12 +336,8 @@ TEST_F(CorePageLoadMetricsObserverTest, DontBackgroundQuickerLoad) {

web_contents()->WasShown();

// Start another provisional load

- StartNavigation(GURL(kDefaultTestUrl2));

- content::RenderFrameHostTester* rfh_tester =

- content::RenderFrameHostTester::For(main_rfh());

- rfh_tester->SimulateNavigationCommit(GURL(kDefaultTestUrl2));

+ NavigateAndCommit(GURL(kDefaultTestUrl2));

SimulateTimingUpdate(timing);

- rfh_tester->SimulateNavigationStop();

// Navigate again to see if the timing updated for the foregrounded load.

NavigateAndCommit(GURL(kDefaultTestUrl));