components/page_load_metrics/browser/page_load_metrics_observer.h - Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/browser/page_load_metrics_observer.h

Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bmcquade@ first review Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/page_load_metrics/browser/metrics_web_contents_observer.cc ('K') | « components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc ('k') | content/public/test/browser_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/browser/page_load_metrics_observer.h

diff --git a/components/page_load_metrics/browser/page_load_metrics_observer.h b/components/page_load_metrics/browser/page_load_metrics_observer.h

index 3b486dcfb5f51382dfbceca90bfc954d90582c0f..033cd227461e713c3dd4db5274b6ccbcac702399 100644

--- a/components/page_load_metrics/browser/page_load_metrics_observer.h

+++ b/components/page_load_metrics/browser/page_load_metrics_observer.h

@@ -84,6 +84,7 @@ struct PageLoadExtraInfo {

// The abort time and time to abort for this page load. If the page was not

// aborted, |abort_type| will be |ABORT_NONE|.

const UserAbortType abort_type;

const base::Optional<base::TimeDelta> time_to_abort;

// Extra information supplied to the page load metrics system from the