components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc - Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc

Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bmcquade@ first review Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/page_load_metrics/browser/metrics_web_contents_observer.cc ('K') | « components/page_load_metrics/browser/metrics_web_contents_observer.cc ('k') | components/page_load_metrics/browser/page_load_metrics_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc

diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc b/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc

index fa9943c06b4eda3c8901cd5750f488f6d61ccb20..1395ecf3b7e0fef5608604e527543deb0075d3f5 100644

--- a/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc

+++ b/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc

@@ -415,7 +415,10 @@ TEST_F(MetricsWebContentsObserverTest, LogAbortChains) {

histogram_tester_.ExpectTotalCount(internal::kAbortChainSizeNewNavigation, 1);

histogram_tester_.ExpectBucketCount(internal::kAbortChainSizeNewNavigation, 3,

1);

- CheckNoErrorEvents();

+ // The second and third navigation signal multiple aborted provisional loads.

+ // This is due to us not calling WillStartNavigationRequest in unit tests.

+ CheckErrorEvent(ERR_NAVIGATION_SIGNALS_MULIPLE_ABORTED_LOADS, 2);

+ CheckTotalErrorEvents();

}

TEST_F(MetricsWebContentsObserverTest, LogAbortChainsSameURL) {