Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: media/filters/source_buffer_stream.cc

Issue 213253006: MSE: Populate WebM missing duration with DefaultDuration, derived, or default (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/source_buffer_stream.cc
diff --git a/media/filters/source_buffer_stream.cc b/media/filters/source_buffer_stream.cc
index a7d3ecf1f0a86eced8aa80623a3d46c81afc553c..df504aa6befae7ef05cf1695cfb71a6c0b5e1609 100644
--- a/media/filters/source_buffer_stream.cc
+++ b/media/filters/source_buffer_stream.cc
@@ -965,7 +965,13 @@ void SourceBufferStream::PrepareRangesForNextAppend(
// Handle splices between the existing buffers and the new buffers. If a
// splice is generated the timestamp and duration of the first buffer in
// |new_buffers| will be modified.
- GenerateSpliceFrame(new_buffers);
+
+ // TODO(dalecurtis): GenerateSpliceFrame() causes crash in
+ // ChunkDemuxerTest.OutOfOrderClusters when all frames in a cluster have
acolwell GONE FROM CHROMIUM 2014/03/26 23:32:04 nit: Remove comment since Dale has already disable
wolenetz 2014/03/27 18:01:48 Done (and rebased onto ToT that now includes Dale'
+ // duration, including SimpleBlock frames whose duration is derived from
+ // a subsequent BlockGroup frame's timestamp for the same track in the
+ // cluster. See http://crbug.com/356805.
+ // GenerateSpliceFrame(new_buffers);
base::TimeDelta prev_timestamp = last_appended_buffer_timestamp_;
bool prev_is_keyframe = last_appended_buffer_is_keyframe_;

Powered by Google App Engine
This is Rietveld 408576698