MSE: Populate WebM missing duration with DefaultDuration, derived, or default

media/filters/source_buffer_stream.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/filters/source_buffer_stream.h"
 
 #include <algorithm>
 #include <map>
 
 #include "base/bind.h"
@@ skipping 947 matching lines @@
       // position.
       // TODO(acolwell): Figure out a more elegant way to do this.
       SeekAndSetSelectedRange(*range_for_next_append_, seek_timestamp);
       temporarily_select_range = true;
     }
   }
 
   // Handle splices between the existing buffers and the new buffers.  If a
   // splice is generated the timestamp and duration of the first buffer in
   // |new_buffers| will be modified.
-  GenerateSpliceFrame(new_buffers);
+
+  // TODO(dalecurtis): GenerateSpliceFrame() causes crash in
+  // ChunkDemuxerTest.OutOfOrderClusters when all frames in a cluster have

[acolwell GONE FROM CHROMIUM, 2014/03/26 23:32:04]

nit: Remove comment since Dale has already disabled the generation for now and I
believe he's aware of the bug mentioned here.

[wolenetz, 2014/03/27 18:01:48]

Done (and rebased onto ToT that now includes Dale's
https://codereview.chromium.org/213283003/ that disables GenerateSpliceFrame()
outside of scoped tests.

+  // duration, including SimpleBlock frames whose duration is derived from
+  // a subsequent BlockGroup frame's timestamp for the same track in the
+  // cluster. See http://crbug.com/356805.
+  // GenerateSpliceFrame(new_buffers);
 
   base::TimeDelta prev_timestamp = last_appended_buffer_timestamp_;
   bool prev_is_keyframe = last_appended_buffer_is_keyframe_;
   base::TimeDelta next_timestamp = new_buffers.front()->GetDecodeTimestamp();
   bool next_is_keyframe = new_buffers.front()->IsKeyframe();
 
   if (prev_timestamp != kNoTimestamp() && prev_timestamp != next_timestamp) {
     // Clean up the old buffers between the last appended buffer and the
     // beginning of |new_buffers|.
     RemoveInternal(prev_timestamp, next_timestamp, true, deleted_buffers);
@@ skipping 1202 matching lines @@
     if (buffer->end_of_stream() || buffer->timestamp() >= end)
       break;
     if (buffer->timestamp() + buffer->duration() <= start)
       continue;
     buffers->push_back(buffer);
   }
   return previous_size < buffers->size();
 }
 
 }  // namespace media