Cleanup redundant method names.

Cleanup redundant method names.

This CL cleans up a bunch of method names which are redundant with the class
names or code location.

Committed: https://pdfium.googlesource.com/pdfium/+/d1cf239fa6be42baa02028efd1617d5af27d82e1

[dsinclair, 2016-07-07 18:18:09]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, weili@chromium.org

[dsinclair, 2016-07-07 18:18:10]

PTAL.

[Lei Zhang, 2016-07-07 19:36:18]

Almost done looking, but gotta run.

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/app/xfa_ffpageview...
File xfa/fxfa/app/xfa_ffpageview.cpp (right):

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/app/xfa_ffpageview...
xfa/fxfa/app/xfa_ffpageview.cpp:94: FX_BOOL IsLayoutElement(XFA_Element
eElement, FX_BOOL bLayoutContainer) {
bools?

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/parser/xfa_script_...
File xfa/fxfa/parser/xfa_script_datawindow.cpp (right):

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/parser/xfa_script_...
xfa/fxfa/parser/xfa_script_datawindow.cpp:23: void
CScript_DataWindow::MoveCurrentRecord(CFXJSE_Arguments* pArguments) {}
I can't figure out what this class is suppose to do.

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/parser/xfa_script_...
File xfa/fxfa/parser/xfa_script_datawindow.h (right):

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/parser/xfa_script_...
xfa/fxfa/parser/xfa_script_datawindow.h:15: CScript_DataWindow(CXFA_Document*
pDocument);
explicit

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/parser/xfa_script_...
File xfa/fxfa/parser/xfa_script_logpseudomodel.cpp (right):

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/parser/xfa_script_...
xfa/fxfa/parser/xfa_script_logpseudomodel.cpp:23: void
CScript_LogPseudoModel::Message(CFXJSE_Arguments* pArguments) {}
Ditto. What's the point?

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/parser/xfa_script_...
File xfa/fxfa/parser/xfa_script_resolveprocessor.h (right):

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/parser/xfa_script_...
xfa/fxfa/parser/xfa_script_resolveprocessor.h:49: int32_t m_iCurStart;
Just add getter/setter as needed?

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/parser/xfa_utils_i...
File xfa/fxfa/parser/xfa_utils_imp.cpp (right):

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/parser/xfa_utils_i...
xfa/fxfa/parser/xfa_utils_imp.cpp:21: const FX_DOUBLE fraction_scales[] = {0.1,
Needs Mario ASCII art.

[dsinclair, 2016-07-07 19:47:49]

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/app/xfa_ffpageview...
File xfa/fxfa/app/xfa_ffpageview.cpp (right):

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/app/xfa_ffpageview...
xfa/fxfa/app/xfa_ffpageview.cpp:94: FX_BOOL IsLayoutElement(XFA_Element
eElement, FX_BOOL bLayoutContainer) {
On 2016/07/07 19:36:18, Lei Zhang wrote:
> bools?

Done.

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/parser/xfa_script_...
File xfa/fxfa/parser/xfa_script_datawindow.cpp (right):

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/parser/xfa_script_...
xfa/fxfa/parser/xfa_script_datawindow.cpp:23: void
CScript_DataWindow::MoveCurrentRecord(CFXJSE_Arguments* pArguments) {}
On 2016/07/07 19:36:18, Lei Zhang wrote:
> I can't figure out what this class is suppose to do.

They're, essentially, dummy callbacks. If you look in
xfa_basic_data_element_script you can see them hooked up to various XFA script
methods like "moveCurrentRecord".

We just happen to not implement anything in DataWindow or Log apparently.

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/parser/xfa_script_...
File xfa/fxfa/parser/xfa_script_datawindow.h (right):

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/parser/xfa_script_...
xfa/fxfa/parser/xfa_script_datawindow.h:15: CScript_DataWindow(CXFA_Document*
pDocument);
On 2016/07/07 19:36:18, Lei Zhang wrote:
> explicit

Done.

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/parser/xfa_script_...
File xfa/fxfa/parser/xfa_script_logpseudomodel.cpp (right):

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/parser/xfa_script_...
xfa/fxfa/parser/xfa_script_logpseudomodel.cpp:23: void
CScript_LogPseudoModel::Message(CFXJSE_Arguments* pArguments) {}
On 2016/07/07 19:36:18, Lei Zhang wrote:
> Ditto. What's the point?

As previous. In theory we'd possibly want an implementation here, but it isn't
done ...

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/parser/xfa_script_...
File xfa/fxfa/parser/xfa_script_resolveprocessor.h (right):

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/parser/xfa_script_...
xfa/fxfa/parser/xfa_script_resolveprocessor.h:49: int32_t m_iCurStart;
On 2016/07/07 19:36:18, Lei Zhang wrote:
> Just add getter/setter as needed?

Done.

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/parser/xfa_utils_i...
File xfa/fxfa/parser/xfa_utils_imp.cpp (right):

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/parser/xfa_utils_i...
xfa/fxfa/parser/xfa_utils_imp.cpp:21: const FX_DOUBLE fraction_scales[] = {0.1,
On 2016/07/07 19:36:18, Lei Zhang wrote:
> Needs Mario ASCII art.

Acknowledged.

[Lei Zhang, 2016-07-07 20:24:06]

lgtm

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/parser/xfa_utils_i...
File xfa/fxfa/parser/xfa_utils_imp.cpp (right):

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/parser/xfa_utils_i...
xfa/fxfa/parser/xfa_utils_imp.cpp:46: FX_BOOL bNegative = FALSE, bExpSign =
FALSE;
One per line, bool.

[dsinclair, 2016-07-11 13:22:39]

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/parser/xfa_utils_i...
File xfa/fxfa/parser/xfa_utils_imp.cpp (right):

https://codereview.chromium.org/2132513003/diff/1/xfa/fxfa/parser/xfa_utils_i...
xfa/fxfa/parser/xfa_utils_imp.cpp:46: FX_BOOL bNegative = FALSE, bExpSign =
FALSE;
On 2016/07/07 20:24:06, Lei Zhang wrote:
> One per line, bool.

Done.

[dsinclair, 2016-07-11 13:22:45]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-07-11 13:22:45]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2132513003/#ps40001
(title: "Review feedback")

[commit-bot: I haz the power, 2016-07-11 13:22:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 13:47:04]

Description was changed from

==========
Cleanup redundant method names.

This CL cleans up a bunch of method names which are redundant with the class
names or code location.
==========

to

==========
Cleanup redundant method names.

This CL cleans up a bunch of method names which are redundant with the class
names or code location.

Committed:
https://pdfium.googlesource.com/pdfium/+/d1cf239fa6be42baa02028efd1617d5af27d...
==========

[commit-bot: I haz the power, 2016-07-11 13:47:05]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/d1cf239fa6be42baa02028efd1617d5af27d...

[commit-bot: I haz the power, 2016-07-11 13:47:07]

CQ bit was unchecked.