Cleanup redundant method names.

xfa/fxfa/app/xfa_ffpageview.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fxfa/include/xfa_ffpageview.h"
 
 #include "xfa/fde/fde_render.h"
 #include "xfa/fxfa/app/xfa_ffcheckbutton.h"
@@ skipping 73 matching lines @@
   if (bTraversal && (dwStatus & XFA_WidgetStatus_Disabled))
     return false;
   if (bIgnorerelevant)
     return !!(dwStatus & XFA_WidgetStatus_Visible);
 
   dwFilter &= (XFA_WidgetStatus_Visible | XFA_WidgetStatus_Viewable |
                XFA_WidgetStatus_Printable);
   return (dwFilter & dwStatus) == dwFilter;
 }
 
+FX_BOOL IsLayoutElement(XFA_Element eElement, FX_BOOL bLayoutContainer) {

[Lei Zhang, 2016/07/07 19:36:18]

bools?

[dsinclair, 2016/07/07 19:47:48]

Done.

+  switch (eElement) {
+    case XFA_Element::Draw:
+    case XFA_Element::Field:
+    case XFA_Element::InstanceManager:
+      return !bLayoutContainer;
+    case XFA_Element::Area:
+    case XFA_Element::Subform:
+    case XFA_Element::ExclGroup:
+    case XFA_Element::SubformSet:
+    case XFA_Element::PageArea:
+    case XFA_Element::Form:
+      return TRUE;
+    default:
+      return FALSE;
+  }
+}
+
 }  // namespace
 
 CXFA_FFPageView::CXFA_FFPageView(CXFA_FFDocView* pDocView, CXFA_Node* pPageArea)
     : CXFA_ContainerLayoutItem(pPageArea), m_pDocView(pDocView) {}
 
 CXFA_FFPageView::~CXFA_FFPageView() {}
 
 CXFA_FFDocView* CXFA_FFPageView::GetDocView() const {
   return m_pDocView;
 }
@@ skipping 262 matching lines @@
         pSearchItem = sIterator->MoveToNext();
         continue;
       }
       if (pContainerItem && (pSearchItem->GetParent() != pContainerItem)) {
         bCurrentItem = TRUE;
         break;
       }
       CXFA_TabParam* pParam = new CXFA_TabParam;
       pParam->m_pWidget = hWidget;
       tabParams.Add(pParam);
-      if (XFA_IsLayoutElement(pSearchItem->GetFormNode()->GetElementType(),
-                              TRUE)) {
+      if (IsLayoutElement(pSearchItem->GetFormNode()->GetElementType(), TRUE)) {
         OrderContainer(sIterator, pSearchItem, pParam, bCurrentItem,
                        bContentArea, bMarsterPage);
       }
     }
     if (bCurrentItem) {
       pSearchItem = sIterator->GetCurrent();
       bCurrentItem = FALSE;
     } else {
       pSearchItem = sIterator->MoveToNext();
     }
@@ skipping 42 matching lines @@
       pWidget->LoadWidget();
     }
     return pWidget;
   }
   return nullptr;
 }
 
 CXFA_TabParam::CXFA_TabParam() : m_pWidget(nullptr) {}
 
 CXFA_TabParam::~CXFA_TabParam() {}