Issue 2132383002: Renamed isParameter to isRegularParameter.

Issue 2132383002: Renamed isParameter to isRegularParameter. (Closed)

Created:
4 years, 5 months ago by eernst

Modified:
4 years, 5 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org, floitsch

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Renamed isParameter to isRegularParameter. This rename was planned a while ago, but it seemed reasonable to take it in a separate CL because of the number of locations affected. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/1011686cf87079a11409db7efa6badcba41f4f5e

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -24 lines)			Patch
M	pkg/compiler/lib/src/closure.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/dart_backend/placeholder_collector.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/elements/common.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/elements/elements.dart	View	1	1 chunk	+7 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/inferrer/node_tracer.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/inferrer/type_graph_nodes.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/backend.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/resolution/members.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/serialization/element_serialization.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/typechecker.dart	View		5 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 6 (2 generated)

Johnni Winther

LGTM Maybe when initializing formals are parameters by default we should add an 'isParameter' property ...

4 years, 5 months ago (2016-07-11 11:43:07 UTC) #3

eernst

On 2016/07/11 11:43:07, Johnni Winther wrote: > LGTM > > Maybe when initializing formals are ...

4 years, 5 months ago (2016-07-12 07:28:29 UTC) #4

eernst

4 years, 5 months ago (2016-07-12 07:31:15 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
1011686cf87079a11409db7efa6badcba41f4f5e (presubmit successful).