Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: pkg/compiler/lib/src/resolution/members.dart

Issue 2132383002: Renamed isParameter to isRegularParameter. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Review response Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/resolution/members.dart
diff --git a/pkg/compiler/lib/src/resolution/members.dart b/pkg/compiler/lib/src/resolution/members.dart
index 7e879799e913de316e8aeb5cfaaea3d00766a7a8..49e6f38b8419db1e55200ebeddfa50f2af80ef96 100644
--- a/pkg/compiler/lib/src/resolution/members.dart
+++ b/pkg/compiler/lib/src/resolution/members.dart
@@ -112,7 +112,7 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
bool isPotentiallyMutableTarget(Element target) {
if (target == null) return false;
- return (target.isVariable || target.isParameter) &&
+ return (target.isVariable || target.isRegularParameter) &&
!(target.isFinal || target.isConst);
}
@@ -879,7 +879,7 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
/// Compute the [AccessSemantics] corresponding to a local access of [target].
AccessSemantics computeLocalAccessSemantics(
Spannable node, LocalElement target) {
- if (target.isParameter) {
+ if (target.isRegularParameter) {
if (target.isFinal || target.isConst) {
return new StaticAccess.finalParameter(target);
} else {
@@ -2559,7 +2559,7 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
ResolutionResult handleLocalUpdate(Send node, Name name, Element element) {
AccessSemantics semantics;
ErroneousElement error;
- if (element.isParameter) {
+ if (element.isRegularParameter) {
if (element.isFinal) {
error = reportAndCreateErroneousElement(node.selector, name.text,
MessageKind.UNDEFINED_STATIC_SETTER_BUT_GETTER, {'name': name});
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | pkg/compiler/lib/src/serialization/element_serialization.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698