Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 213223003: Add ability to pass through IDWriteFactory so sandbox can control how it's constructed (Closed)

Created:
6 years, 8 months ago by scottmg
Modified:
6 years, 8 months ago
Reviewers:
eae, dglazkov
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, abarth-chromium, danakj, dglazkov+blink, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Add ability to pass through IDWriteFactory so sandbox can control how it's constructed Skia supports receiving a factory after Skia r14000. Plumb a pointer through here so that the sandbox warmup code, see https://codereview.chromium.org/217813008 can control how it's constructed. R=eae@chromium.org BUG=333029 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M Source/platform/fonts/FontCache.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/platform/fonts/FontCache.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/fonts/win/FontCacheSkiaWin.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/win/WebFontRendering.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M public/web/win/WebFontRendering.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
scottmg
6 years, 8 months ago (2014-04-02 02:50:21 UTC) #1
eae
LGTM
6 years, 8 months ago (2014-04-02 02:52:47 UTC) #2
eae
The CQ bit was checked by eae@chromium.org
6 years, 8 months ago (2014-04-02 02:53:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/213223003/1
6 years, 8 months ago (2014-04-02 02:53:13 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 03:02:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 8 months ago (2014-04-02 03:02:27 UTC) #6
scottmg
+dglazkov for OWNERS
6 years, 8 months ago (2014-04-02 03:42:26 UTC) #7
dglazkov
rslgtm.
6 years, 8 months ago (2014-04-02 16:28:27 UTC) #8
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 8 months ago (2014-04-02 16:29:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/213223003/1
6 years, 8 months ago (2014-04-02 16:29:44 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 16:41:41 UTC) #11
Message was sent while issue was closed.
Change committed as 170669

Powered by Google App Engine
This is Rietveld 408576698