Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2178)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: blimp/client/public/BUILD.gn

Issue 2132163002: Add BlimpClientContext and factory with real and dummy implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-blimp-client-core-public-to-blimp-client
Patch Set: Added delegate-support to BlimpClientContext Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« blimp/client/core/blimp_client_context_impl_unittest.cc ('K') | « blimp/client/dummy/dummy_blimp_client_context.cc ('k') | blimp/client/public/DEPS » ('j') | chrome/android/java/src/org/chromium/chrome/browser/blimp/ChromeBlimpClientContextDelegate.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/public/BUILD.gn
diff --git a/blimp/client/public/BUILD.gn b/blimp/client/public/BUILD.gn
index bd422f4a91e2395e776a5dce2369307dbc59df72..f0829acadf25e1174fb9890a8459dfa9c307bda7 100644
--- a/blimp/client/public/BUILD.gn
+++ b/blimp/client/public/BUILD.gn
@@ -9,6 +9,8 @@ if (is_android) {
source_set("public") {
sources = [
+ "blimp_client_context.h",
+ "blimp_client_context_delegate.h",
"blimp_contents.h",
"blimp_contents_observer.h",
"blimp_navigation_controller.h",
@@ -16,13 +18,19 @@ source_set("public") {
deps = [
"//base",
+ "//components/keyed_service/core",
"//url",
]
+
+ if (is_android) {
+ sources += [ "android/blimp_jni_registrar.h" ]
+ }
}
if (is_android) {
android_library("public_java") {
java_files = [
+ "android/java/src/org/chromium/blimp_public/BlimpClientContext.java",
"android/java/src/org/chromium/blimp_public/BlimpContents.java",
"android/java/src/org/chromium/blimp_public/BlimpContentsObserver.java",
"android/java/src/org/chromium/blimp_public/BlimpNavigationController.java",
« blimp/client/core/blimp_client_context_impl_unittest.cc ('K') | « blimp/client/dummy/dummy_blimp_client_context.cc ('k') | blimp/client/public/DEPS » ('j') | chrome/android/java/src/org/chromium/chrome/browser/blimp/ChromeBlimpClientContextDelegate.java » ('J')

Powered by Google App Engine
This is Rietveld 408576698