Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: chrome/browser/password_manager/native_backend_libsecret_unittest.cc

Issue 2132063002: Implement origin-based deletion for password manager's auto-signin bit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed PasswordStoreMac Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_libsecret_unittest.cc
diff --git a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc b/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
index 85fac007474275492daf2305b3b855d7b0698363..f3ecee1e8032b2c72f37cab1429f5d24ddfd2a2d 100644
--- a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
+++ b/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
@@ -887,7 +887,7 @@ TEST_F(NativeBackendLibsecretTest, RemoveLoginsSyncedBetween) {
CheckRemoveLoginsBetween(SYNCED);
}
-TEST_F(NativeBackendLibsecretTest, DisableAutoSignInForAllLogins) {
+TEST_F(NativeBackendLibsecretTest, DisableAutoSignInForOrigins) {
NativeBackendLibsecret backend(42);
backend.Init();
form_google_.skip_zero_click = false;
@@ -906,16 +906,22 @@ TEST_F(NativeBackendLibsecretTest, DisableAutoSignInForAllLogins) {
PasswordStoreChangeList expected_changes;
expected_changes.push_back(
PasswordStoreChange(PasswordStoreChange::UPDATE, form_facebook_));
- expected_changes.push_back(
- PasswordStoreChange(PasswordStoreChange::UPDATE, form_google_));
PasswordStoreChangeList changes;
- EXPECT_TRUE(backend.DisableAutoSignInForAllLogins(&changes));
+ EXPECT_TRUE(backend.DisableAutoSignInForOrigins(
+ base::Bind(&GURL::operator==, base::Unretained(&form_facebook_.origin)),
+ &changes));
CheckPasswordChanges(expected_changes, changes);
EXPECT_EQ(2u, global_mock_libsecret_items->size());
- for (const auto& item : *global_mock_libsecret_items)
- CheckUint32Attribute(item, "should_skip_zero_click", 1);
+ CheckStringAttribute((*global_mock_libsecret_items)[0],
+ "origin_url", form_google_.origin.spec());
+ CheckUint32Attribute((*global_mock_libsecret_items)[0],
+ "should_skip_zero_click", 0);
+ CheckStringAttribute((*global_mock_libsecret_items)[1],
+ "origin_url", form_facebook_.origin.spec());
+ CheckUint32Attribute((*global_mock_libsecret_items)[1],
+ "should_skip_zero_click", 1);
}
TEST_F(NativeBackendLibsecretTest, SomeKeyringAttributesAreMissing) {

Powered by Google App Engine
This is Rietveld 408576698