chrome/browser/password_manager/native_backend_libsecret.cc - Issue 2132063002: Implement origin-based deletion for password manager's auto-signin bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/native_backend_libsecret.cc

Issue 2132063002: Implement origin-based deletion for password manager's auto-signin bit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed PasswordStoreMac Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/native_backend_libsecret.h ('k') | chrome/browser/password_manager/native_backend_libsecret_unittest.cc » ('j') | chrome/browser/password_manager/password_store_x_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/native_backend_libsecret.cc

diff --git a/chrome/browser/password_manager/native_backend_libsecret.cc b/chrome/browser/password_manager/native_backend_libsecret.cc

index 7d5b258c123816582f95feb14cd047109afeb46f..7ad4ed4d50cce14af0a6785e0fb56833f6998eff 100644

--- a/chrome/browser/password_manager/native_backend_libsecret.cc

+++ b/chrome/browser/password_manager/native_backend_libsecret.cc

@@ -281,14 +281,15 @@ bool NativeBackendLibsecret::RemoveLoginsSyncedBetween(

return RemoveLoginsBetween(delete_begin, delete_end, SYNC_TIMESTAMP, changes);

}

-bool NativeBackendLibsecret::DisableAutoSignInForAllLogins(

+bool NativeBackendLibsecret::DisableAutoSignInForOrigins(

+ const base::Callback<bool(const GURL&)>& origin_filter,

password_manager::PasswordStoreChangeList* changes) {

ScopedVector<autofill::PasswordForm> all_forms;

if (!GetLoginsList(nullptr, ALL_LOGINS, &all_forms))

return false;

for (auto& form : all_forms) {

- if (!form->skip_zero_click) {

+ if (origin_filter.Run(form->origin) && !form->skip_zero_click) {

form->skip_zero_click = true;

if (!UpdateLogin(*form, changes))

return false;