components/ntp_snippets/content_suggestions_service.cc - Issue 2131943002: Change NTPSnippetsService to implement ContentSuggestionsProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/content_suggestions_service.cc

Issue 2131943002: Change NTPSnippetsService to implement ContentSuggestionsProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@neuerservice2

Patch Set: Insert the default-case again because some compilers need it Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/content_suggestions_provider.cc ('k') | components/ntp_snippets/ntp_snippets_service.h » ('j') | components/ntp_snippets/ntp_snippets_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/content_suggestions_service.cc

diff --git a/components/ntp_snippets/content_suggestions_service.cc b/components/ntp_snippets/content_suggestions_service.cc

index 5b86d95762303e6662ad7e1569dad31efca147f0..3ce179f48df90fd5b6e6555960d86e1302e6e683 100644

--- a/components/ntp_snippets/content_suggestions_service.cc

+++ b/components/ntp_snippets/content_suggestions_service.cc

@@ -61,7 +61,7 @@ void ContentSuggestionsService::FetchSuggestionImage(

ContentSuggestionsCategory category = id_category_map_[suggestion_id];

if (!providers_.count(category)) {

LOG(WARNING) << "Requested image for suggestion " << suggestion_id

- << " for unavailable category " << int(category);

+ << " for unavailable category " << static_cast<int>(category);

callback.Run(suggestion_id, gfx::Image());

return;

}

@@ -92,7 +92,7 @@ void ContentSuggestionsService::DiscardSuggestion(

ContentSuggestionsCategory category = id_category_map_[suggestion_id];

if (!providers_.count(category)) {

LOG(WARNING) << "Discarded suggestion " << suggestion_id

- << " for unavailable category " << int(category);

+ << " for unavailable category " << static_cast<int>(category);

return;

}

providers_[category]->DiscardSuggestion(suggestion_id);