components/ntp_snippets/content_suggestions_provider.cc - Issue 2131943002: Change NTPSnippetsService to implement ContentSuggestionsProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/content_suggestions_provider.cc

Issue 2131943002: Change NTPSnippetsService to implement ContentSuggestionsProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@neuerservice2

Patch Set: Insert the default-case again because some compilers need it Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/content_suggestions_provider.h ('k') | components/ntp_snippets/content_suggestions_service.cc » ('j') | components/ntp_snippets/ntp_snippets_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/content_suggestions_provider.cc

diff --git a/components/ntp_snippets/content_suggestions_provider.cc b/components/ntp_snippets/content_suggestions_provider.cc

index 696a3813ae76c47cb62cf469873ebe8fa2604f6f..e4565e59d1c708b6f67650e3999940c5e44dd937 100644

--- a/components/ntp_snippets/content_suggestions_provider.cc

+++ b/components/ntp_snippets/content_suggestions_provider.cc

@@ -23,7 +23,8 @@ ContentSuggestionsProvider::~ContentSuggestionsProvider() {}

std::string ContentSuggestionsProvider::MakeUniqueID(

ContentSuggestionsCategory category,

const std::string& within_category_id) {

- return base::StringPrintf(kCombinedIDFormat, int(category),

+ return base::StringPrintf(kCombinedIDFormat,

+ static_cast<int>(category),

within_category_id.c_str());

}