chrome/browser/ui/webui/snippets_internals_message_handler.cc - Issue 2131943002: Change NTPSnippetsService to implement ContentSuggestionsProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/snippets_internals_message_handler.cc

Issue 2131943002: Change NTPSnippetsService to implement ContentSuggestionsProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@neuerservice2

Patch Set: Insert the default-case again because some compilers need it Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ntp_snippets/ntp_snippets_service_factory.cc ('k') | components/ntp_snippets/content_suggestions_category_status.h » ('j') | components/ntp_snippets/ntp_snippets_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/snippets_internals_message_handler.cc

diff --git a/chrome/browser/ui/webui/snippets_internals_message_handler.cc b/chrome/browser/ui/webui/snippets_internals_message_handler.cc

index 89a20ea01d9e530e8b99530093d77f2a8015dfac..f6e7411baf0ca1ad6ad5cf19a64dda6b3303b449 100644

--- a/chrome/browser/ui/webui/snippets_internals_message_handler.cc

+++ b/chrome/browser/ui/webui/snippets_internals_message_handler.cc

@@ -114,14 +114,14 @@ void SnippetsInternalsMessageHandler::HandleLoaded(

void SnippetsInternalsMessageHandler::HandleClear(const base::ListValue* args) {

DCHECK_EQ(0u, args->GetSize());

- ntp_snippets_service_->ClearSnippets();

+ ntp_snippets_service_->ClearCachedSuggestionsForDebugging();

}

void SnippetsInternalsMessageHandler::HandleClearDiscarded(

const base::ListValue* args) {

DCHECK_EQ(0u, args->GetSize());

- ntp_snippets_service_->ClearDiscardedSnippets();

+ ntp_snippets_service_->ClearDiscardedSuggestionsForDebugging();

SendDiscardedSnippets();

}