Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: components/ntp_snippets/content_suggestions_category_status.h

Issue 2131943002: Change NTPSnippetsService to implement ContentSuggestionsProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@neuerservice2
Patch Set: Insert the default-case again because some compilers need it Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/content_suggestions_category_status.h
diff --git a/components/ntp_snippets/content_suggestions_category_status.h b/components/ntp_snippets/content_suggestions_category_status.h
index d3b5ba474baa18b8f345a80c890ea9ef466869d0..16b65af028bac7483e0e0bba18283b115bcffaa2 100644
--- a/components/ntp_snippets/content_suggestions_category_status.h
+++ b/components/ntp_snippets/content_suggestions_category_status.h
@@ -11,6 +11,10 @@ namespace ntp_snippets {
// On Android builds, a Java counterpart will be generated for this enum.
// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.ntp.snippets
enum class ContentSuggestionsCategoryStatus {
+ // The provider is still initializing and it is not yet determined whether
+ // content suggestions will be available or not.
+ INITIALIZING,
+
// Content suggestions are available (though the list of available suggestions
// may be empty simply because there are no reasonable suggestions to be made
// at the moment).
@@ -36,9 +40,10 @@ enum class ContentSuggestionsCategoryStatus {
PASSPHRASE_ENCRYPTION_ENABLED,
// Content suggestions are not available because history sync is disabled.
HISTORY_SYNC_DISABLED,
- // Content suggestions are not available because the history sync service is
- // not yet completely initialized and its status is unknown.
- HISTORY_SYNC_STATE_UNKNOWN
+
+ // Content suggestions are not available because an error occured when loading
+ // or updating them.
+ LOADING_ERROR
};
// Determines whether the given status is one of the AVAILABLE statuses.

Powered by Google App Engine
This is Rietveld 408576698