chrome/browser/android/ntp/ntp_snippets_bridge.cc - Issue 2131943002: Change NTPSnippetsService to implement ContentSuggestionsProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/ntp/ntp_snippets_bridge.cc

Issue 2131943002: Change NTPSnippetsService to implement ContentSuggestionsProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@neuerservice2

Patch Set: Insert the default-case again because some compilers need it Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/ntp/ntp_snippets_bridge.cc

diff --git a/chrome/browser/android/ntp/ntp_snippets_bridge.cc b/chrome/browser/android/ntp/ntp_snippets_bridge.cc

index e6e9cddcabc6b6cd4be5747c33f3e1f74a292eb0..373de14c8c375514d5a2045b5272095207e5892c 100644

--- a/chrome/browser/android/ntp/ntp_snippets_bridge.cc

+++ b/chrome/browser/android/ntp/ntp_snippets_bridge.cc

@@ -93,7 +93,7 @@ void NTPSnippetsBridge::FetchImage(JNIEnv* env,

const JavaParamRef<jstring>& snippet_id,

const JavaParamRef<jobject>& j_callback) {

base::android::ScopedJavaGlobalRef<jobject> callback(j_callback);

- ntp_snippets_service_->FetchSnippetImage(

+ ntp_snippets_service_->FetchSuggestionImage(

ConvertJavaStringToUTF8(env, snippet_id),

base::Bind(&NTPSnippetsBridge::OnImageFetched,

weak_ptr_factory_.GetWeakPtr(), callback));

@@ -102,7 +102,7 @@ void NTPSnippetsBridge::FetchImage(JNIEnv* env,

void NTPSnippetsBridge::DiscardSnippet(JNIEnv* env,

const JavaParamRef<jobject>& obj,

const JavaParamRef<jstring>& id) {

- ntp_snippets_service_->DiscardSnippet(ConvertJavaStringToUTF8(env, id));

+ ntp_snippets_service_->DiscardSuggestion(ConvertJavaStringToUTF8(env, id));

}

void NTPSnippetsBridge::SnippetVisited(JNIEnv* env,

« no previous file with comments | « no previous file | chrome/browser/ntp_snippets/ntp_snippets_service_factory.cc » ('j') | components/ntp_snippets/ntp_snippets_service.cc » ('J')