Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: chrome/browser/android/ntp/ntp_snippets_bridge.cc

Issue 2131943002: Change NTPSnippetsService to implement ContentSuggestionsProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@neuerservice2
Patch Set: Insert the default-case again because some compilers need it Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/ntp/ntp_snippets_bridge.h" 5 #include "chrome/browser/android/ntp/ntp_snippets_bridge.h"
6 6
7 #include <jni.h> 7 #include <jni.h>
8 8
9 #include "base/android/callback_android.h" 9 #include "base/android/callback_android.h"
10 #include "base/android/jni_android.h" 10 #include "base/android/jni_android.h"
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 const JavaParamRef<jobject>& j_observer) { 86 const JavaParamRef<jobject>& j_observer) {
87 observer_.Reset(env, j_observer); 87 observer_.Reset(env, j_observer);
88 NTPSnippetsServiceLoaded(); 88 NTPSnippetsServiceLoaded();
89 } 89 }
90 90
91 void NTPSnippetsBridge::FetchImage(JNIEnv* env, 91 void NTPSnippetsBridge::FetchImage(JNIEnv* env,
92 const JavaParamRef<jobject>& obj, 92 const JavaParamRef<jobject>& obj,
93 const JavaParamRef<jstring>& snippet_id, 93 const JavaParamRef<jstring>& snippet_id,
94 const JavaParamRef<jobject>& j_callback) { 94 const JavaParamRef<jobject>& j_callback) {
95 base::android::ScopedJavaGlobalRef<jobject> callback(j_callback); 95 base::android::ScopedJavaGlobalRef<jobject> callback(j_callback);
96 ntp_snippets_service_->FetchSnippetImage( 96 ntp_snippets_service_->FetchSuggestionImage(
97 ConvertJavaStringToUTF8(env, snippet_id), 97 ConvertJavaStringToUTF8(env, snippet_id),
98 base::Bind(&NTPSnippetsBridge::OnImageFetched, 98 base::Bind(&NTPSnippetsBridge::OnImageFetched,
99 weak_ptr_factory_.GetWeakPtr(), callback)); 99 weak_ptr_factory_.GetWeakPtr(), callback));
100 } 100 }
101 101
102 void NTPSnippetsBridge::DiscardSnippet(JNIEnv* env, 102 void NTPSnippetsBridge::DiscardSnippet(JNIEnv* env,
103 const JavaParamRef<jobject>& obj, 103 const JavaParamRef<jobject>& obj,
104 const JavaParamRef<jstring>& id) { 104 const JavaParamRef<jstring>& id) {
105 ntp_snippets_service_->DiscardSnippet(ConvertJavaStringToUTF8(env, id)); 105 ntp_snippets_service_->DiscardSuggestion(ConvertJavaStringToUTF8(env, id));
106 } 106 }
107 107
108 void NTPSnippetsBridge::SnippetVisited(JNIEnv* env, 108 void NTPSnippetsBridge::SnippetVisited(JNIEnv* env,
109 const JavaParamRef<jobject>& obj, 109 const JavaParamRef<jobject>& obj,
110 const JavaParamRef<jobject>& jcallback, 110 const JavaParamRef<jobject>& jcallback,
111 const JavaParamRef<jstring>& jurl) { 111 const JavaParamRef<jstring>& jurl) {
112 base::android::ScopedJavaGlobalRef<jobject> callback(jcallback); 112 base::android::ScopedJavaGlobalRef<jobject> callback(jcallback);
113 113
114 history_service_->QueryURL( 114 history_service_->QueryURL(
115 GURL(ConvertJavaStringToUTF8(env, jurl)), 115 GURL(ConvertJavaStringToUTF8(env, jurl)),
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 if (!image.IsEmpty()) 191 if (!image.IsEmpty())
192 j_bitmap = gfx::ConvertToJavaBitmap(image.ToSkBitmap()); 192 j_bitmap = gfx::ConvertToJavaBitmap(image.ToSkBitmap());
193 193
194 base::android::RunCallbackAndroid(callback, j_bitmap); 194 base::android::RunCallbackAndroid(callback, j_bitmap);
195 } 195 }
196 196
197 // static 197 // static
198 bool NTPSnippetsBridge::Register(JNIEnv* env) { 198 bool NTPSnippetsBridge::Register(JNIEnv* env) {
199 return RegisterNativesImpl(env); 199 return RegisterNativesImpl(env);
200 } 200 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698