Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2131713002: Reland: Fix DexLoaderTest#testLoadAfterDeleteCachedDexes() flakiness part 2/2 (Closed)

Created:
4 years, 5 months ago by pkotwicz
Modified:
4 years, 5 months ago
Reviewers:
Xi Han
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Fix DexLoaderTest#testLoadAfterDeleteCachedDexes() flakiness part 2/2 There seems to be data cached by the OS which is not deleted by DexLoader#deleteCachedDexes() which is causing the test to be flaky. This CL changes DexLoaderTest#testLoadAfterDeleteCachedDexes() to test DexLoader#deleteCachedDexes() in a scenario which is closer to how the function is used in production. The test used to test that calling DexLoader#deleteCachedDexes() would make DexLoader#load() load a dex file from scratch. The CL changes the test to test that: - DexLoader#deleteCachedDexes() deletes previously extracted dexes from the local data directory - It is possible to use reuse a data directory to load several dexes Original CL: https://codereview.chromium.org/2033953002 BUG=616923 Committed: https://crrev.com/36e19af6ecccfdd9940ac9dcf219edbd735a3a3a Cr-Commit-Position: refs/heads/master@{#404280}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -35 lines) Patch
M chrome/android/webapk/shell_apk/javatests/src/org/chromium/webapk/shell_apk/DexLoaderTest.java View 3 chunks +29 lines, -35 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
pkotwicz
Xi can you please take a look?
4 years, 5 months ago (2016-07-07 21:01:48 UTC) #2
Xi Han
lgtm
4 years, 5 months ago (2016-07-07 21:14:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131713002/1
4 years, 5 months ago (2016-07-07 21:18:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
4 years, 5 months ago (2016-07-07 23:20:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131713002/1
4 years, 5 months ago (2016-07-08 00:07:30 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 00:46:46 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 00:47:05 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 00:50:04 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36e19af6ecccfdd9940ac9dcf219edbd735a3a3a
Cr-Commit-Position: refs/heads/master@{#404280}

Powered by Google App Engine
This is Rietveld 408576698