Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2033953002: Fix DexLoaderTest#testLoadAfterDeleteCachedDexes() flakiness (Closed)

Created:
4 years, 6 months ago by pkotwicz
Modified:
4 years, 6 months ago
Reviewers:
Xi Han
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DexLoaderTest#testLoadAfterDeleteCachedDexes() flakiness There seems to be data cached by the OS which is not deleted by DexLoader#deleteCachedDexes() which is causing the test to be flaky. This CL changes DexLoaderTest#testLoadAfterDeleteCachedDexes() to test DexLoader#deleteCachedDexes() in a scenario which is closer to how the function is used in production. The test used to test that calling DexLoader#deleteCachedDexes() would make DexLoader#load() load a dex file from scratch. The CL changes the test to test that: - DexLoader#deleteCachedDexes() deletes previously extracted dexes from the local data directory - It is possible to use reuse a data directory to load several dexes BUG=616923 Committed: https://crrev.com/c59b7de12ab8878ddfe4df4fe5cd91b0d526b8c2 Cr-Commit-Position: refs/heads/master@{#398198}

Patch Set 1 : #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Messages

Total messages: 14 (8 generated)
pkotwicz
Xi, can you please take a look?
4 years, 6 months ago (2016-06-03 00:23:06 UTC) #5
Xi Han
lgtm https://codereview.chromium.org/2033953002/diff/40001/chrome/android/webapk/shell_apk/javatests/src/org/chromium/webapk/shell_apk/DexLoaderTest.java File chrome/android/webapk/shell_apk/javatests/src/org/chromium/webapk/shell_apk/DexLoaderTest.java (right): https://codereview.chromium.org/2033953002/diff/40001/chrome/android/webapk/shell_apk/javatests/src/org/chromium/webapk/shell_apk/DexLoaderTest.java#newcode241 chrome/android/webapk/shell_apk/javatests/src/org/chromium/webapk/shell_apk/DexLoaderTest.java:241: DexLoader.load(mRemoteContext, "canary2.dex", canaryClassName2, null, mLocalDexDir); Please make the ...
4 years, 6 months ago (2016-06-06 20:10:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033953002/60001
4 years, 6 months ago (2016-06-07 00:39:05 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 6 months ago (2016-06-07 02:16:40 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/c59b7de12ab8878ddfe4df4fe5cd91b0d526b8c2 Cr-Commit-Position: refs/heads/master@{#398198}
4 years, 6 months ago (2016-06-07 02:19:00 UTC) #13
timvolodine
4 years, 6 months ago (2016-06-07 12:42:25 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/2041333003/ by timvolodine@chromium.org.

The reason for reverting is: looks like this broke the Android Tests (dbg) bot
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Test...

also see crbug.com/617935.

Powered by Google App Engine
This is Rietveld 408576698