Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2131603002: Print preview: make page/sheet summary locale aware (Closed)

Created:
4 years, 5 months ago by Dan Beam
Modified:
4 years, 5 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Print preview: make page/sheet summary locale aware R=dpapad@chromium.org BUG=617540 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/314dd0c72e7921f4aec79dd700db5dd3562c3e39 Cr-Commit-Position: refs/heads/master@{#404196}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M chrome/browser/resources/print_preview/print_header.js View 1 chunk +16 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Dan Beam
4 years, 5 months ago (2016-07-07 17:05:22 UTC) #4
Dan Beam
screenshot: http://i.imgur.com/UY2AeKS.png
4 years, 5 months ago (2016-07-07 17:05:51 UTC) #5
dpapad
lgtm
4 years, 5 months ago (2016-07-07 17:23:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131603002/1
4 years, 5 months ago (2016-07-07 18:36:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 18:57:29 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 18:57:40 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 18:59:31 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/314dd0c72e7921f4aec79dd700db5dd3562c3e39
Cr-Commit-Position: refs/heads/master@{#404196}

Powered by Google App Engine
This is Rietveld 408576698