Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Unified Diff: chrome/browser/resources/print_preview/print_header.js

Issue 2131603002: Print preview: make page/sheet summary locale aware (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/print_preview/print_header.js
diff --git a/chrome/browser/resources/print_preview/print_header.js b/chrome/browser/resources/print_preview/print_header.js
index 51f25e7a058fd4ea2cc51d0ff647a9b78819a3c5..4eec37f72592045c4054ed8d4785160011151798 100644
--- a/chrome/browser/resources/print_preview/print_header.js
+++ b/chrome/browser/resources/print_preview/print_header.js
@@ -188,20 +188,25 @@ cr.define('print_preview', function() {
var html;
var label;
if (numPages != numSheets) {
- html = loadTimeData.getStringF('printPreviewSummaryFormatLong',
- '<b>' + numSheets + '</b>',
- '<b>' + summaryLabel + '</b>',
- numPages,
- pagesLabel);
+ html = loadTimeData.getStringF(
+ 'printPreviewSummaryFormatLong',
+ '<b>' + numSheets.toLocaleString() + '</b>',
+ '<b>' + summaryLabel + '</b>',
+ numPages.toLocaleString(),
+ pagesLabel);
label = loadTimeData.getStringF('printPreviewSummaryFormatLong',
- numSheets, summaryLabel,
- numPages, pagesLabel);
+ numSheets.toLocaleString(),
+ summaryLabel,
+ numPages.toLocaleString(),
+ pagesLabel);
} else {
- html = loadTimeData.getStringF('printPreviewSummaryFormatShort',
- '<b>' + numSheets + '</b>',
- '<b>' + summaryLabel + '</b>');
+ html = loadTimeData.getStringF(
+ 'printPreviewSummaryFormatShort',
+ '<b>' + numSheets.toLocaleString() + '</b>',
+ '<b>' + summaryLabel + '</b>');
label = loadTimeData.getStringF('printPreviewSummaryFormatShort',
- numSheets, summaryLabel);
+ numSheets.toLocaleString(),
+ summaryLabel);
}
// Removing extra spaces from within the string.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698