Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Issue 2131463004: Added AboutFlags_document-passive-event-listeners action to actions.xml. (Closed)

Created:
4 years, 5 months ago by bruthig
Modified:
4 years, 5 months ago
Reviewers:
dtapuska, rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added AboutFlags_document-passive-event-listeners action to actions.xml. It appears that extract_actions.py was never run to add the new command line flag to actions.xml in https://codereview.chromium.org/2125683002. This was causing presubmit failures when trying to update actions.xml for other metrics. BUG=None Committed: https://crrev.com/064f5070b5646186aa4b42f310ef717466a8dce4 Cr-Commit-Position: refs/heads/master@{#404386}

Patch Set 1 #

Patch Set 2 : Update owner and description. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M tools/metrics/actions/actions.xml View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
bruthig
Can you please take a look?
4 years, 5 months ago (2016-07-07 17:02:43 UTC) #2
dtapuska
lgtm
4 years, 5 months ago (2016-07-07 17:08:45 UTC) #3
rkaplow
lgtm thanks for fixing!
4 years, 5 months ago (2016-07-08 14:28:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131463004/20001
4 years, 5 months ago (2016-07-08 14:30:44 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-08 14:36:31 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 14:36:34 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 14:39:11 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/064f5070b5646186aa4b42f310ef717466a8dce4
Cr-Commit-Position: refs/heads/master@{#404386}

Powered by Google App Engine
This is Rietveld 408576698