Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2125683002: Add option to force document level passive event listeners as a runtime feature. (Closed)

Created:
4 years, 5 months ago by dtapuska
Modified:
4 years, 5 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, asvitkine+watch_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add option to force document level passive event listeners as a runtime feature. This approach removes the value from the override setting and allows it to be set as a runtime feature. Since field trial variations aren't supported in the renderer and only the browser process adding an additional runtime enabled feature seems the easiest approach forward. BUG=625675 Committed: https://crrev.com/acc2fb2eaf19f06817b8ef90b64b195d032a662a Cr-Commit-Position: refs/heads/master@{#403972}

Patch Set 1 #

Patch Set 2 : Update value #

Total comments: 1

Patch Set 3 : Remove status=test; I'll add status=experimental in a follow up CL #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -21 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M content/child/runtime_features.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/content_features.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_features.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/events/AddEventListenerOptionsDefaults.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/EventTarget.cpp View 2 chunks +14 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/AssertMatchingEnums.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebSettings.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
dtapuska
4 years, 5 months ago (2016-07-05 15:52:21 UTC) #2
dtapuska
creis@chromium.org: Please review changes in content/*
4 years, 5 months ago (2016-07-05 15:53:43 UTC) #4
rkaplow
lgtm
4 years, 5 months ago (2016-07-05 15:54:24 UTC) #5
Rick Byers
LGTM https://codereview.chromium.org/2125683002/diff/20001/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right): https://codereview.chromium.org/2125683002/diff/20001/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in#newcode157 third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:157: PassiveDocumentEventListeners status=test May be worth using status=experimental - ...
4 years, 5 months ago (2016-07-06 14:35:18 UTC) #6
Charlie Reis
content/ LGTM.
4 years, 5 months ago (2016-07-06 17:25:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125683002/60001
4 years, 5 months ago (2016-07-06 21:26:33 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-06 23:26:43 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 23:26:47 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 23:28:15 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/acc2fb2eaf19f06817b8ef90b64b195d032a662a
Cr-Commit-Position: refs/heads/master@{#403972}

Powered by Google App Engine
This is Rietveld 408576698