Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 2131463002: Purge the App Launcher code from Mac (Closed)

Created:
4 years, 5 months ago by tapted
Modified:
4 years, 5 months ago
Reviewers:
calamity, oshima
CC:
chromium-reviews, extensions-reviews_chromium.org, Matt Giuca, tapted, tfarina, dcheng, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Purge the App Launcher code from Mac It hasn't been compiled for 1 milestone (since r394856). BUG=600915 Committed: https://crrev.com/85b4387b13d7747b8645d3c2cb70507a486a5850 Cr-Commit-Position: refs/heads/master@{#404275}

Patch Set 1 #

Patch Set 2 : Zap mac-specific icon assets #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7599 lines) Patch
M chrome/app/theme/chrome_unscaled_resources.grd View 1 1 chunk +0 lines, -20 lines 1 comment Download
D chrome/app/theme/chromium/mac/app_list_128.png View 1 Binary file 0 comments Download
D chrome/app/theme/chromium/mac/app_list_16.png View 1 Binary file 0 comments Download
D chrome/app/theme/chromium/mac/app_list_256.png View 1 Binary file 0 comments Download
D chrome/app/theme/chromium/mac/app_list_32.png View 1 Binary file 0 comments Download
M chrome/browser/ui/app_list/app_context_menu_unittest.cc View 1 chunk +2 lines, -10 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_controller_browsertest.cc View 1 chunk +1 line, -8 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_controller_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/browser/ui/app_list/app_list_service_cocoa_mac.h View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/ui/app_list/app_list_service_cocoa_mac.mm View 1 chunk +0 lines, -85 lines 0 comments Download
D chrome/browser/ui/app_list/app_list_service_mac.h View 1 chunk +0 lines, -98 lines 0 comments Download
D chrome/browser/ui/app_list/app_list_service_mac.mm View 1 chunk +0 lines, -581 lines 0 comments Download
D chrome/browser/ui/app_list/app_list_service_mac_interactive_uitest.mm View 1 chunk +0 lines, -130 lines 0 comments Download
D chrome/browser/ui/app_list/app_list_service_mac_unittest.mm View 1 chunk +0 lines, -316 lines 0 comments Download
M chrome/browser/ui/app_list/extension_app_context_menu.cc View 3 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/web_applications/web_app.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/web_applications/web_app.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/BUILD.gn View 2 chunks +0 lines, -45 lines 0 comments Download
M ui/app_list/PRESUBMIT.py View 1 chunk +1 line, -6 lines 0 comments Download
M ui/app_list/app_list.gyp View 4 chunks +0 lines, -60 lines 0 comments Download
D ui/app_list/cocoa/app_list_pager_view.h View 1 chunk +0 lines, -43 lines 0 comments Download
D ui/app_list/cocoa/app_list_pager_view.mm View 1 chunk +0 lines, -167 lines 0 comments Download
D ui/app_list/cocoa/app_list_view_controller.h View 1 chunk +0 lines, -81 lines 0 comments Download
D ui/app_list/cocoa/app_list_view_controller.mm View 1 chunk +0 lines, -608 lines 0 comments Download
D ui/app_list/cocoa/app_list_view_controller_unittest.mm View 1 chunk +0 lines, -98 lines 0 comments Download
D ui/app_list/cocoa/app_list_window_controller.h View 1 chunk +0 lines, -26 lines 0 comments Download
D ui/app_list/cocoa/app_list_window_controller.mm View 1 chunk +0 lines, -82 lines 0 comments Download
D ui/app_list/cocoa/app_list_window_controller_unittest.mm View 1 chunk +0 lines, -95 lines 0 comments Download
D ui/app_list/cocoa/apps_collection_view_drag_manager.h View 1 chunk +0 lines, -65 lines 0 comments Download
D ui/app_list/cocoa/apps_collection_view_drag_manager.mm View 1 chunk +0 lines, -263 lines 0 comments Download
D ui/app_list/cocoa/apps_grid_controller.h View 1 chunk +0 lines, -127 lines 0 comments Download
D ui/app_list/cocoa/apps_grid_controller.mm View 1 chunk +0 lines, -709 lines 0 comments Download
D ui/app_list/cocoa/apps_grid_controller_unittest.mm View 1 chunk +0 lines, -979 lines 0 comments Download
D ui/app_list/cocoa/apps_grid_view_item.h View 1 chunk +0 lines, -56 lines 0 comments Download
D ui/app_list/cocoa/apps_grid_view_item.mm View 1 chunk +0 lines, -455 lines 0 comments Download
D ui/app_list/cocoa/apps_pagination_model_observer.h View 1 chunk +0 lines, -26 lines 0 comments Download
D ui/app_list/cocoa/apps_search_box_controller.h View 1 chunk +0 lines, -68 lines 0 comments Download
D ui/app_list/cocoa/apps_search_box_controller.mm View 1 chunk +0 lines, -403 lines 0 comments Download
D ui/app_list/cocoa/apps_search_box_controller_unittest.mm View 1 chunk +0 lines, -270 lines 0 comments Download
D ui/app_list/cocoa/apps_search_results_controller.h View 1 chunk +0 lines, -59 lines 0 comments Download
D ui/app_list/cocoa/apps_search_results_controller.mm View 1 chunk +0 lines, -469 lines 0 comments Download
D ui/app_list/cocoa/apps_search_results_controller_unittest.mm View 1 chunk +0 lines, -301 lines 0 comments Download
D ui/app_list/cocoa/apps_search_results_model_bridge.h View 1 chunk +0 lines, -53 lines 0 comments Download
D ui/app_list/cocoa/apps_search_results_model_bridge.mm View 1 chunk +0 lines, -126 lines 0 comments Download
D ui/app_list/cocoa/item_drag_controller.h View 1 chunk +0 lines, -44 lines 0 comments Download
D ui/app_list/cocoa/item_drag_controller.mm View 1 chunk +0 lines, -184 lines 0 comments Download
D ui/app_list/cocoa/scroll_view_with_no_scrollbars.h View 1 chunk +0 lines, -30 lines 0 comments Download
D ui/app_list/cocoa/scroll_view_with_no_scrollbars.mm View 1 chunk +0 lines, -71 lines 0 comments Download
D ui/app_list/cocoa/test/apps_grid_controller_test_helper.h View 1 chunk +0 lines, -69 lines 0 comments Download
D ui/app_list/cocoa/test/apps_grid_controller_test_helper.mm View 1 chunk +0 lines, -120 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
tapted
Hi Chris, please take a look
4 years, 5 months ago (2016-07-07 04:17:36 UTC) #3
tapted
updated chrome_unscaled_resources.grd https://codereview.chromium.org/2131463002/diff/20001/chrome/app/theme/chrome_unscaled_resources.grd File chrome/app/theme/chrome_unscaled_resources.grd (left): https://codereview.chromium.org/2131463002/diff/20001/chrome/app/theme/chrome_unscaled_resources.grd#oldcode80 chrome/app/theme/chrome_unscaled_resources.grd:80: <include name="IDR_APP_LIST_16" file="google_chrome/mac/app_list_16.png" type="BINDATA" /> CL for ...
4 years, 5 months ago (2016-07-07 06:31:14 UTC) #5
calamity
lgtm
4 years, 5 months ago (2016-07-07 07:16:29 UTC) #6
tapted
+oshima for chrome/app/theme OWNERS - thanks!
4 years, 5 months ago (2016-07-07 11:33:08 UTC) #8
oshima
lgtm
4 years, 5 months ago (2016-07-07 14:28:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131463002/20001
4 years, 5 months ago (2016-07-07 23:13:46 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-08 00:30:11 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 00:30:48 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 00:32:29 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/85b4387b13d7747b8645d3c2cb70507a486a5850
Cr-Commit-Position: refs/heads/master@{#404275}

Powered by Google App Engine
This is Rietveld 408576698