Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/browser/ui/app_list/extension_app_context_menu.cc

Issue 2131463002: Purge the App Launcher code from Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Zap mac-specific icon assets Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/extension_app_context_menu.cc
diff --git a/chrome/browser/ui/app_list/extension_app_context_menu.cc b/chrome/browser/ui/app_list/extension_app_context_menu.cc
index 39d939b680d3845d08d90965eb8b9dfeea2c2ea1..ca05fca8ae0c78f11d7b1092a2109a9bd2501e86 100644
--- a/chrome/browser/ui/app_list/extension_app_context_menu.cc
+++ b/chrome/browser/ui/app_list/extension_app_context_menu.cc
@@ -105,18 +105,11 @@ void ExtensionAppContextMenu::BuildMenu(ui::SimpleMenuModel* menu_model) {
USE_LAUNCH_TYPE_WINDOW,
IDS_APP_CONTEXT_MENU_OPEN_WINDOW);
}
-#if defined(OS_MACOSX)
- // Mac does not support standalone web app browser windows or maximize.
- menu_model->AddCheckItemWithStringId(
- USE_LAUNCH_TYPE_FULLSCREEN,
- IDS_APP_CONTEXT_MENU_OPEN_FULLSCREEN);
-#else
// Even though the launch type is Full Screen it is more accurately
// described as Maximized in Ash.
menu_model->AddCheckItemWithStringId(
USE_LAUNCH_TYPE_FULLSCREEN,
IDS_APP_CONTEXT_MENU_OPEN_MAXIMIZED);
-#endif
}
menu_model->AddSeparator(ui::NORMAL_SEPARATOR);
}
@@ -160,11 +153,6 @@ base::string16 ExtensionAppContextMenu::GetLabelForCommandId(
DCHECK_EQ(LAUNCH_NEW, command_id);
-#if defined(OS_MACOSX)
- // Full screen on Mac launches in a tab.
- bool launches_in_window = extensions::util::CanHostedAppsOpenInWindows() &&
- IsCommandIdChecked(USE_LAUNCH_TYPE_WINDOW);
-#else
// If --enable-new-bookmark-apps is enabled, then only check if
// USE_LAUNCH_TYPE_WINDOW is checked, as USE_LAUNCH_TYPE_PINNED (i.e. open
// as pinned tab) and fullscreen-by-default windows do not exist.
@@ -173,7 +161,6 @@ base::string16 ExtensionAppContextMenu::GetLabelForCommandId(
? IsCommandIdChecked(USE_LAUNCH_TYPE_WINDOW)
: !(IsCommandIdChecked(USE_LAUNCH_TYPE_PINNED) ||
IsCommandIdChecked(USE_LAUNCH_TYPE_REGULAR)));
-#endif
return launches_in_window ?
l10n_util::GetStringUTF16(IDS_APP_LIST_CONTEXT_MENU_NEW_WINDOW) :

Powered by Google App Engine
This is Rietveld 408576698