Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 2131453002: 🎦 Add missing dep when emma_coverage=true (Closed)

Created:
4 years, 5 months ago by agrieve
Modified:
4 years, 5 months ago
Reviewers:
jbudorick
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing dep when emma_coverage=true Broken by https://codereview.chromium.org/2109293003 BUG=620034, 626179 Committed: https://crrev.com/49df176be50454d0c8ca6c37ec0ccfb29223f19d Cr-Commit-Position: refs/heads/master@{#404148}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/config/android/rules.gni View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
agrieve
On 2016/07/07 02:51:30, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org
4 years, 5 months ago (2016-07-07 02:51:34 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131453002/1
4 years, 5 months ago (2016-07-07 02:52:11 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-07 04:25:17 UTC) #7
jbudorick
lgtm
4 years, 5 months ago (2016-07-07 12:56:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131453002/1
4 years, 5 months ago (2016-07-07 13:41:55 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 13:46:19 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 13:48:46 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/49df176be50454d0c8ca6c37ec0ccfb29223f19d
Cr-Commit-Position: refs/heads/master@{#404148}

Powered by Google App Engine
This is Rietveld 408576698